Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_order_warn_message: Migration to 16.0 #2760

Merged

Conversation

manuelregidor
Copy link
Contributor

Supersedes: #2610

@rousseldenis
Copy link
Contributor

@manuelregidor Could you please review #2610 instead ?

@HaraldPanten
Copy link
Contributor

@rousseldenis I'm not sure if #2610 is going to be continued. Remember that it was you who had to rebase. This one is going to be continued.

Can we continue in this one?

@HaraldPanten
Copy link
Contributor

On the other hand, we're keeping more commit history, etc. I think Manuel's one is going to be better.

@HaraldPanten
Copy link
Contributor

/ocabot migration sale_order_warn_message

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 3, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 3, 2023
97 tasks
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review in local environment, as it seems that runboat is being a little bit picky these days.

@pedrobaeza @rousseldenis do you mind having a quick look here?

THX

@pedrobaeza pedrobaeza changed the title 16.0 mig sale order warn message [16.0][MIG] sale_order_warn_message: Migration to 16.0 Nov 3, 2023
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuelregidor please remember to put a proper PR title

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2760-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d2b2d03 into OCA:16.0 Nov 3, 2023
4 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7ca41be. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 16.0-mig-sale_order_warn_message branch November 3, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants