Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX sale_properties_dynamic_fields and sale_order_lot_selection tests #266

Merged
merged 4 commits into from Feb 26, 2016

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Feb 23, 2016

As it seems something does wrong with writing mrp.property.group field with '!record' YAML statement

This avoids 'Field name must be 'x_length', False found'

Also: a34789f

@pedrobaeza
Copy link
Member

I'm afraid there's still errors.

@eLBati eLBati changed the title FIX sale_properties_dynamic_fields tests FIX sale_properties_dynamic_fields and sale_order_lot_selection tests Feb 23, 2016
@eLBati
Copy link
Member Author

eLBati commented Feb 23, 2016

@pedrobaeza at the moment I am not able to reproduce locally travis error KeyError: u'x_depth'

Also, I fixed a34789f but now I'm getting

2016-02-23 18:03:37,767 8494 ERROR demo_8 openerp.addons.sale_order_lot_selection.tests.test_sale_order_lot_selection: `     self.assertEqual(lot10_qty[self.product_14.id]['qty_available'], 1)
2016-02-23 18:03:37,767 8494 ERROR demo_8 openerp.addons.sale_order_lot_selection.tests.test_sale_order_lot_selection: ` AssertionError: 2.0 != 1

So, somewhere something changed since the last build. Tomorrow I'll try to find out what

Every hint is obviously well accepted

As it seems something does wrong with writing mrp.property.group field with '!record' YAML statement

This avoids 'Field name must be 'x_length', False found'
@eLBati eLBati force-pushed the fix_sale_properties_dynamic_fields_tests branch from a34789f to 4ec64a7 Compare February 24, 2016 15:22
@eLBati eLBati force-pushed the fix_sale_properties_dynamic_fields_tests branch from 4ec64a7 to bb0868c Compare February 24, 2016 15:38
@eLBati
Copy link
Member Author

eLBati commented Feb 24, 2016

Now green 💚
Please review

@tafaRU
Copy link
Member

tafaRU commented Feb 25, 2016

Thanks! 👍

@pedrobaeza
Copy link
Member

Thank you very much!

👍

@rafaelbn
Copy link
Member

Thanks! 👍

rafaelbn added a commit that referenced this pull request Feb 26, 2016
…s_tests

FIX sale_properties_dynamic_fields and sale_order_lot_selection tests
@rafaelbn rafaelbn merged commit d576911 into OCA:8.0 Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants