[ADD][8.0] sale_service_project: New module. #226

sergio-teruel · 2015-10-17T09:59:19Z

Create project and tasks with works and materials from sale orders

oca-clabot · 2015-11-11T05:38:19Z

Hey @sergio-incaser, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

Sergio Teruel (no github login found)

Appreciation of efforts,
OCA CLAbot

rafaelbn · 2015-11-14T03:22:31Z

sale_service_project/__openerp__.py

+        'wizard/product_price_service_view.xml',
+    ],
+    'author': 'Incaser Informatica S.L., '
+              'Antiun Ingeniería S.L., '


Change order

rafaelbn · 2015-11-14T03:23:42Z

  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3119405-226-9cfbaf/openerp/addons/base/module/module.py", line 393, in state_update
    raise orm.except_orm(_('Error'), _("You try to install module '%s' that depends on module '%s'.\nBut the latter module is not available in your system.") % (module.name, dep.name,))
except_orm: ('Error', u"You try to install module 'sale_service_project' that depends on module 'project_task_materials'.\nBut the latter module is not available in your system.")

rafaelbn · 2015-11-14T03:24:39Z

Please rebase @sergio-incaser

rafaelbn · 2015-11-17T00:35:06Z

ping @sergio-incaser please rebase for testing, thanks

rafaelbn · 2015-12-09T23:50:58Z

Please @sergio-incaser , rebase and review if runbot fails, thanks!

yajo · 2015-12-10T14:44:47Z

sale_service_project/README.rst

+Sale Service Project
+====================
+
+This module was written to extends the functionality of sale workflow


"This module extends..."

yajo · 2015-12-10T15:06:26Z

Tested in localhost, it seems to work fine, but please fix those comments above.

rafaelbn · 2015-12-11T21:30:30Z

As commented today we must fix:

contract in sale order is parent of new proyect with task of sale order
in the analytic account associated with the proyect of sale order there is no cost of material, onyl units

rafaelbn · 2015-12-15T23:45:33Z

Hi @carlos-incaser @sergio-incaser runbot fails

    openerp.service.server:942 preload_registries

Failed to initialize database `3137323-226-8be756-all`.
Traceback (most recent call last):
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3137323-226-8be756/openerp/service/server.py", line 929, in preload_registries
    registry = RegistryManager.new(dbname, update_module=update_module)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3137323-226-8be756/openerp/modules/registry.py", line 370, in new
    openerp.modules.load_modules(registry._db, force_demo, status, update_module)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3137323-226-8be756/openerp/modules/loading.py", line 319, in load_modules
    modobj.button_install(cr, SUPERUSER_ID, ids)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3137323-226-8be756/openerp/api.py", line 256, in wrapper
    return old_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3137323-226-8be756/openerp/addons/base/module/module.py", line 414, in button_install
    self.state_update(cr, uid, ids, 'to install', ['uninstalled'], context=context)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3137323-226-8be756/openerp/api.py", line 256, in wrapper
    return old_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3137323-226-8be756/openerp/api.py", line 387, in old_api
    result = method(recs, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3137323-226-8be756/openerp/addons/base/module/module.py", line 393, in state_update
    raise orm.except_orm(_('Error'), _("You try to install module '%s' that depends on module '%s'.\nBut the latter module is not available in your system.") % (module.name, dep.name,))
except_orm: ('Error', u"You try to install module 'sale_service_project' that depends on module 'project_task_materials'.\nBut the latter module is not available in your system.")

yajo · 2016-02-12T14:57:43Z

sale_service_project/models/project.py

+                    all_inv = False
+            task.analytic_line_ids = lines
+            task.invoice_ids = invoice_ids
+            task.invoice_exists = invoice_ids and True or False


Do you mean bool(invoice_ids)?

Exactly, thanks

yajo · 2016-02-12T15:10:12Z

Code reviewed, but I see lots of functionality added and no new comments in README, code or PR. Maybe this is just WIP or bug fixing, but otherwise please explain yourself when publishing changes so we reviewers know what to review.

carlosdauden · 2016-02-15T08:33:58Z

At this time the module is WIP.
What I should do for that someone with permissions adds the WIP label?

yajo · 2016-02-15T14:39:39Z

You can also add [WIP] to the title. In such case, please someone remove needs review. Thanks for clarifying, I'll wait to review.

…ate SO

…nges.

rafaelbn · 2016-02-19T19:18:54Z

Hi, thanks! Tested locally 👍 we must check travis.

rafaelbn · 2016-02-19T19:22:21Z

sale_service_project/README.rst

+====================
+Sale Service Project
+====================
+


This module helps you to manage task created from sales order, let you choose if you wants to invoice from sale order or from task, and helps you to control with sale order must be invoiced or not depending if the task have been done or not.

carlosdauden · 2016-02-22T08:39:25Z

Travis fails in sale_properties_dynamic_fields module.
Can I do something or this error isn't related with my module?

rafaelbn · 2016-02-22T17:49:23Z

cc @pedrobaeza

pedrobaeza · 2016-02-23T17:47:50Z

This PR is supposed to fix Travis: #266

rafaelbn · 2016-02-23T17:51:22Z

OK, I merge as this module has been reviewed technically and functionally and all comments and fixed have been apply.

[ADD][8.0] sale_service_project: New module.

sergio-teruel added 3 commits October 17, 2015 11:55

[ADD][8.0] sale_service_project: New module.

d0aefde

[ADD][8.0] sale_service_project: Readme change id repo.

f179e0e

[IMP] sale_service_project: Add project to oca_dependencies.txt

9cfbaff

sergio-teruel mentioned this pull request Nov 14, 2015

[ADD][8.0] sale_service_fleet: New module. #227

Merged

rafaelbn reviewed Nov 14, 2015
View reviewed changes

rafaelbn added the needs review label Dec 9, 2015

rafaelbn added this to the 8.0 milestone Dec 9, 2015

rafaelbn self-assigned this Dec 9, 2015

yajo reviewed Dec 10, 2015
View reviewed changes

rafaelbn added the needs fixing label Dec 11, 2015

[FIX][8.0] sale_service_project: Changes suggested by @yajo

8be7560

[FIX][8.0] sale_service_project: Create subprojects

64e02b1

[IMP] sale_service_project: Check if task is closed

b9df248

yajo reviewed Feb 12, 2016
View reviewed changes

elicoidal added the work in progress label Feb 15, 2016

rafaelbn removed the needs review label Feb 15, 2016

carlosdauden added 5 commits February 15, 2016 19:47

[IMP][8.0] sale_service_project: Changes suggested by @yajo

fa764c0

[IMP][8.0] sale_service_project: Copy works and materials when duplic…

7b6a2e3

…ate SO

[IMP][8.0] sale_service_project: Task closed control in Sale Order Line

e2d0cc4

[IMP][8.0] sale_service_project: Invoice report from tasks. Minor cha…

0e7f055

…nges.

[IMP][8.0] sale_service_project: Minor fix

8f9203d

rafaelbn added needs review and removed work in progress labels Feb 19, 2016

rafaelbn reviewed Feb 19, 2016
View reviewed changes

[FIX] sale_service_project: Rename material_id to product_id

10d7d21

yajo mentioned this pull request Feb 22, 2016

Migration of sale_properties_dynamic_fields #147

Merged

[IMP][8.0] sale_service_project: Clean up comments and improved readme

a250f02

rafaelbn added a commit that referenced this pull request Feb 23, 2016

Merge pull request #226 from incaser/sale_service_project

181d953

[ADD][8.0] sale_service_project: New module.

rafaelbn merged commit 181d953 into OCA:8.0 Feb 23, 2016

yvaucher removed the needs review label Feb 23, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD][8.0] sale_service_project: New module. #226

[ADD][8.0] sale_service_project: New module. #226

sergio-teruel commented Oct 17, 2015

oca-clabot commented Nov 11, 2015

rafaelbn Nov 14, 2015

rafaelbn commented Nov 14, 2015

rafaelbn commented Nov 14, 2015

rafaelbn commented Nov 17, 2015

rafaelbn commented Dec 9, 2015

yajo Dec 10, 2015

yajo commented Dec 10, 2015

rafaelbn commented Dec 11, 2015

rafaelbn commented Dec 15, 2015

yajo Feb 12, 2016

carlosdauden Feb 15, 2016

yajo commented Feb 12, 2016

carlosdauden commented Feb 15, 2016

yajo commented Feb 15, 2016

rafaelbn commented Feb 19, 2016

rafaelbn Feb 19, 2016

carlosdauden commented Feb 22, 2016

rafaelbn commented Feb 22, 2016

pedrobaeza commented Feb 23, 2016

rafaelbn commented Feb 23, 2016

[ADD][8.0] sale_service_project: New module. #226

[ADD][8.0] sale_service_project: New module. #226

Conversation

sergio-teruel commented Oct 17, 2015

oca-clabot commented Nov 11, 2015

rafaelbn Nov 14, 2015

Choose a reason for hiding this comment

rafaelbn commented Nov 14, 2015

rafaelbn commented Nov 14, 2015

rafaelbn commented Nov 17, 2015

rafaelbn commented Dec 9, 2015

yajo Dec 10, 2015

Choose a reason for hiding this comment

yajo commented Dec 10, 2015

rafaelbn commented Dec 11, 2015

rafaelbn commented Dec 15, 2015

yajo Feb 12, 2016

Choose a reason for hiding this comment

carlosdauden Feb 15, 2016

Choose a reason for hiding this comment

yajo commented Feb 12, 2016

carlosdauden commented Feb 15, 2016

yajo commented Feb 15, 2016

rafaelbn commented Feb 19, 2016

rafaelbn Feb 19, 2016

Choose a reason for hiding this comment

carlosdauden commented Feb 22, 2016

rafaelbn commented Feb 22, 2016

pedrobaeza commented Feb 23, 2016

rafaelbn commented Feb 23, 2016