Migration of sale_line_quantity_properties_based #146

tafaRU · 2015-05-05T09:58:51Z

This PR depends on #147 which also depends on #167 (both merged)

gurneyalex · 2015-06-25T05:15:26Z

sale_line_quantity_properties_based/sale_order_line.py

+                }
+                try:
+                    exec self.product_id.quantity_formula_id.\
+                        formula_text in localdict


use safe_eval (from openerp.tools.safe_eval) in exec mode. Not perfect, but limits the code injection risks.

@gurneyalex, done at tafaRU@bfe4905
Sorry to bother you but #167 needs to be merged asap so that I can unblock this one, #147 and #145

Thanks!

gurneyalex · 2015-11-25T10:13:50Z

sale_line_quantity_properties_based/README.rst

+    10 [pcs of] (4 m x 0.5 m) shelves = 20 m² of wood
+
+In order to have this function working, it is necessary to have the user
+proceeding as follows:


I think s/proceeding/proceed/

(but I'm French...)

tafaRU · 2016-02-12T15:36:24Z

@gurneyalex, I addressed your last remarks and the PR now should be ready to be merged.
Please have a look at it.

eLBati · 2016-02-12T17:08:25Z

.travis.yml

@@ -35,6 +35,8 @@ env:
  - TESTS="1" ODOO_REPO="OCA/OCB" INCLUDE="sale_sourced_by_line_sale_transport_multi_address" LINT_CHECK="0"
  - TESTS="1" ODOO_REPO="odoo/odoo" INCLUDE="sale_properties_dynamic_fields" LINT_CHECK="0"
  - TESTS="1" ODOO_REPO="OCA/OCB" INCLUDE="sale_properties_dynamic_fields" LINT_CHECK="0"
+  - TESTS="1" ODOO_REPO="odoo/odoo" INCLUDE="sale__line_quantity_properties_based" LINT_CHECK="0"
+  - TESTS="1" ODOO_REPO="OCA/OCB" INCLUDE="sale__line_quantity_properties_based" LINT_CHECK="0"


too many underscores

Also, I think sale_properties_dynamic_fields and sale_line_quantity_properties_based can be tested together if possible

tafaRU · 2016-02-18T08:18:59Z

@eLBati, done, thanks!

eLBati · 2016-03-02T17:48:47Z

@tafaRU please check tests

eLBati · 2016-03-02T17:51:13Z

Maybe a rebase can help, after #266

tafaRU · 2016-03-03T08:13:19Z

@eLBati, just rebased, let's see.

tafaRU · 2016-03-03T09:20:15Z

@eLBati travis is still red, further investigation is needed then.

coveralls · 2016-04-11T13:11:11Z

Coverage increased (+1.5%) to 73.17% when pulling 99aa782 on tafaRU:8.0-sale_line_quantity_properties_based-migr into e3251d6 on OCA:8.0.

atchuthan · 2016-04-12T05:42:37Z

@tafaRU In .travis.yml, why do we still test with INCLUDE/EXCLUDE?
d6b210a

@pedrobaeza suggested on removing INCLUDE/EXCLUDE as it was designed for older testing versions in OCA and to adapt our travis for new version test.

tafaRU · 2016-04-14T13:12:11Z

@atchuthan, thanks for your help

Could you please give me some reference about this?

@pedrobaeza suggested on removing INCLUDE/EXCLUDE as it was designed for older testing versions in OCA and to adapt our travis for new version test.

…erties_based

…dy depends by it

…ame way done for v7.0

To do this I apply the following changes: - depends from sale_properties_dynamic_fields instead of sale_properties_easy_creation - onchange (v8) only depends by property_ids - get empty properties and get empty properties dynamic fields in on_change (v7)

…s_qty

…tions

…ion list

…me feedback, rather than silently doing nothing.

gurneyalex · 2016-10-05T13:16:37Z

👍

pedrobaeza · 2016-10-05T13:18:37Z

You finally made it!

I will prefer as you know some commit squashing and module renaming, but after all the work, I approve this.

Signed-off-by simahawk

tafaRU added the work in progress label May 5, 2015

tafaRU force-pushed the 8.0-sale_line_quantity_properties_based-migr branch from 0769b16 to 20f31ca Compare June 19, 2015 09:49

gurneyalex reviewed Jun 25, 2015
View reviewed changes

tafaRU force-pushed the 8.0-sale_line_quantity_properties_based-migr branch from 33724ef to c45977b Compare June 25, 2015 09:57

tafaRU force-pushed the 8.0-sale_line_quantity_properties_based-migr branch 3 times, most recently from cb30149 to d8ca31c Compare November 16, 2015 11:39

tafaRU mentioned this pull request Nov 16, 2015

[8.0] Migration of sale_properties_easy_creation #167

Merged

tafaRU force-pushed the 8.0-sale_line_quantity_properties_based-migr branch from d8ca31c to 742e860 Compare November 17, 2015 13:50

tafaRU force-pushed the 8.0-sale_line_quantity_properties_based-migr branch from 742e860 to 2495847 Compare November 25, 2015 10:08

gurneyalex reviewed Nov 25, 2015
View reviewed changes

eLBati reviewed Feb 12, 2016
View reviewed changes

tafaRU force-pushed the 8.0-sale_line_quantity_properties_based-migr branch 2 times, most recently from 9efef72 to 212a23e Compare February 18, 2016 08:15

tafaRU force-pushed the 8.0-sale_line_quantity_properties_based-migr branch from 212a23e to 2f93741 Compare February 18, 2016 09:43

tafaRU force-pushed the 8.0-sale_line_quantity_properties_based-migr branch from 2f93741 to 411769c Compare February 26, 2016 14:09

tafaRU force-pushed the 8.0-sale_line_quantity_properties_based-migr branch from 411769c to e9c50fa Compare March 3, 2016 08:12

Add code using by 'git checkout origin/7.0 -- sale_line_quantity_prop…

489d026

…erties_based

tafaRU and others added 21 commits October 3, 2016 14:45

Fix field name, changed in V8

aabdbb8

Inherit view from sale_mrp instead of sale_stock

304d5ff

Update copyright year

3f60999

Extract the description in README.rst

7f0e03a

Add OCA icon

ee9b3b3

Rem sale_mrp from depends because sale_properties_easy_creation alrea…

d915871

…dy depends by it

[FIX] using new API for property_ids onchange

ad23bd2

Fix onchange method name and remove brackets from exec

54590a3

Add product_id_change to avoid product_uos_qty recomputation in the s…

d31003d

…ame way done for v7.0

Delete sale_order_view.xml since is useless now

42c8921

Add product_uos_qty as parameter of onchange to recompute quantity

a543321

Quantity recalculation has to be done when property_ids or product_uo…

dfba982

…s_qty

Calculate quantity by using compute_formula method

59060f7

Improve README and update module version according to last OCA conven…

3b02591

…tions

Modify .travis to test sale__line_quantity_properties_based separately

97e6bc9

Fix typos in README file

ce3b860

Improve quantity_property_ids_changed: use .ids instead of comprehens…

b843de3

…ion list

Return warning instead of add it to the log, so that the user gets so…

02d1ede

…me feedback, rather than silently doing nothing.

Update it.po

ea38ce4

Add uos_id to localdict

dcab80a

tafaRU force-pushed the 8.0-sale_line_quantity_properties_based-migr branch 2 times, most recently from 6f7e19f to dcab80a Compare October 3, 2016 14:23

[FIX] KeyError: 'product_uom_qty'

f4ada6e

gurneyalex added needs review and removed work in progress labels Oct 5, 2016

eLBati merged commit 22c2d77 into OCA:8.0 Feb 17, 2017

lmignon pushed a commit to acsone/sale-workflow that referenced this pull request Feb 11, 2021

Merge PR OCA#146 into 13.0

658386d

Signed-off-by simahawk

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migration of sale_line_quantity_properties_based #146

Migration of sale_line_quantity_properties_based #146

tafaRU commented May 5, 2015 •

edited by gurneyalex

Loading

gurneyalex Jun 25, 2015

tafaRU Nov 16, 2015

gurneyalex Nov 25, 2015

tafaRU commented Feb 12, 2016

eLBati Feb 12, 2016

eLBati Feb 12, 2016

tafaRU commented Feb 18, 2016

eLBati commented Mar 2, 2016

eLBati commented Mar 2, 2016

tafaRU commented Mar 3, 2016

tafaRU commented Mar 3, 2016

coveralls commented Apr 11, 2016

atchuthan commented Apr 12, 2016

tafaRU commented Apr 14, 2016

gurneyalex commented Oct 5, 2016

pedrobaeza commented Oct 5, 2016

Migration of sale_line_quantity_properties_based #146

Migration of sale_line_quantity_properties_based #146

Conversation

tafaRU commented May 5, 2015 • edited by gurneyalex Loading

gurneyalex Jun 25, 2015

Choose a reason for hiding this comment

tafaRU Nov 16, 2015

Choose a reason for hiding this comment

gurneyalex Nov 25, 2015

Choose a reason for hiding this comment

tafaRU commented Feb 12, 2016

eLBati Feb 12, 2016

Choose a reason for hiding this comment

eLBati Feb 12, 2016

Choose a reason for hiding this comment

tafaRU commented Feb 18, 2016

eLBati commented Mar 2, 2016

eLBati commented Mar 2, 2016

tafaRU commented Mar 3, 2016

tafaRU commented Mar 3, 2016

coveralls commented Apr 11, 2016

atchuthan commented Apr 12, 2016

tafaRU commented Apr 14, 2016

gurneyalex commented Oct 5, 2016

pedrobaeza commented Oct 5, 2016

tafaRU commented May 5, 2015 •

edited by gurneyalex

Loading