Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [11.0] password_security - redirection fails when password_secu… #124

Closed
wants to merge 1 commit into from

Conversation

amkarthik
Copy link
Member

This PR fixes the redirection to reset password page when the logging in user's password is expired.

'login_success' param is set in request params when the user successfully logged in. This is introduced in the commit odoo/odoo@a1fac87 to redirect the user to backend or front end based on their access rights.

As we kick out the user when the logging in user's password is expired, we can set the 'login_success' param to False. This will avoid the redirection in the website module controller and will redirect us to password reset page.

This PR fixes #119.

@amkarthik
Copy link
Member Author

PR #125 is for v12.0

@amkarthik
Copy link
Member Author

@pedrobaeza
Please review this.

@pedrobaeza
Copy link
Member

Sorry, but it's out of my scope.

@amkarthik
Copy link
Member Author

Sorry, but it's out of my scope.

Thanks for the reply.

Copy link

@Martronic-SA Martronic-SA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Rebased to 11.0-ocabot-merge-pr-124-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 5, 2019
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 51a2677. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 11.0.

@OCA-git-bot OCA-git-bot changed the title [FIX] [11.0] password_security - redirection fails when password_secu… [FIX] [11.0] password_security - redirection fails when password_secu… Aug 5, 2019
@OCA-git-bot OCA-git-bot closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants