-
-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] [12.0] password_security - redirection fails when password_secu… #125
Conversation
…rity and website module installed.
@pedrobaeza |
Sorry, but it's out of my scope. |
Thanks for the reply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested functionality in Runbot 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
I'd like to test this PR but don't know how, could you please add the steps to reproduce the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't manage to reproduce the issue, but checked the code and seems ok, thanks!
This PR has the |
@SimoRubi |
/ocabot merge patch |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 24b755c. Thanks a lot for contributing to OCA. ❤️ |
This PR fixes the redirection to reset password page when the user password is expired.
'login_success' param is set in request params when the user successfully logged in. This is introduced in the commit odoo/odoo@a1fac87 to redirect the user to backend or front end based on the access rights.
As we kick out the user when the logging in user's password is expired, we can set the 'login_success' param to False. This will avoid the redirection in the website module controller and will redirect us to the password reset page.