Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] [12.0] password_security - redirection fails when password_secu… #125

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

amkarthik
Copy link
Member

This PR fixes the redirection to reset password page when the user password is expired.

'login_success' param is set in request params when the user successfully logged in. This is introduced in the commit odoo/odoo@a1fac87 to redirect the user to backend or front end based on the access rights.

As we kick out the user when the logging in user's password is expired, we can set the 'login_success' param to False. This will avoid the redirection in the website module controller and will redirect us to the password reset page.

@amkarthik
Copy link
Member Author

@pedrobaeza
Please review this.

@pedrobaeza
Copy link
Member

Sorry, but it's out of my scope.

@amkarthik
Copy link
Member Author

Sorry, but it's out of my scope.

Thanks for the reply.

Copy link
Member

@atchuthan atchuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functionality in Runbot 👍

Copy link
Member

@SimoRubi SimoRubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!
I'd like to test this PR but don't know how, could you please add the steps to reproduce the issue?

Copy link
Member

@SimoRubi SimoRubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't manage to reproduce the issue, but checked the code and seems ok, thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@amkarthik
Copy link
Member Author

@SimoRubi
To reproduce this we need to install the password_security module and website module.
And make any one user password to expire. And login with that user.

@dreispt
Copy link
Member

dreispt commented Mar 30, 2020

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-125-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5c99669 into OCA:12.0 Mar 30, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 24b755c. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot changed the title [FIX] [12.0] password_security - redirection fails when password_secu… [FIX] [12.0] password_security - redirection fails when password_secu… Mar 30, 2020
llacroix pushed a commit to archeti-org/server-auth that referenced this pull request Dec 9, 2020
Signed-off-by dreispt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants