[16][MIG ] module_analysis #2609

florian-dacosta · 2023-04-18T14:44:46Z

Replace #2608

Sorry I guess I did a wrong manipulation, I could not reopen the other after a force push.

fixup! [ADD] new module module_analysis fixup! fixup! [ADD] new module module_analysis fixup! fixup! fixup! [ADD] new module module_analysis fixup! fixup! fixup! fixup! [ADD] new module module_analysis IMP exception message fixup! fixup! fixup! fixup! fixup! [ADD] new module module_analysis [REF] remove use of cloc. use pygount librairy instead fixup! [REF] remove use of cloc. use pygount librairy instead fixup! fixup! [REF] remove use of cloc. use pygount librairy instead Apply suggestions from code review Co-Authored-By: David Beal <david.beal@akretion.com> Update module_analysis/views/menu.xml Co-Authored-By: David Beal <david.beal@akretion.com> Update module_analysis/tests/test_module.py Co-Authored-By: David Beal <david.beal@akretion.com> Update module_analysis/readme/CONFIGURE.rst Co-Authored-By: David Beal <david.beal@akretion.com> [IMP] handle encoding [UPD] Update module_analysis.pot [UPD] README.rst [UPD] README.rst

Currently translated at 100.0% (35 of 35 strings) Translation: server-tools-12.0/server-tools-12.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-module_analysis/zh_CN/ [UPD] README.rst

Currently translated at 100.0% (35 of 35 strings) Translation: server-tools-13.0/server-tools-13.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-module_analysis/it/

[MIG] module_analysis: Migration to 15.0

…cause the analysis is partial (it also make the update slower) ; Add instead a cron task that is executed nightly to update analysis automatically

Currently translated at 97.2% (35 of 36 strings) Translation: server-tools-15.0/server-tools-15.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-module_analysis/it/

Analyse can take some time and a cron task can do it every day if needed, no need to recompute it in real time

…e there is no post install hook anymore

florian-dacosta · 2023-04-18T15:05:08Z

@legalsylvain

Why 8e5457e

In general I prefer all cron to be unactive at installation, mainly this kind of cron that you have to do some configuration (better change the time to run it at night at least, etc). It does not change a lot to unactivate it because you have to configure it anyway.
Having active cron of the kind is annoying for test database, CI, preprod, etc...

You'll tell me if it is acceptable for you, else I'll remove the commit so we can go forward

legalsylvain · 2023-04-18T15:15:33Z

I have no clear point of view.
In one hand, you removed the analysis in the post_install part, and you set active to false for the cron. So when we install the module, now, nothing "work", (and will work) and the configuration is now mandatory.
In the other hand, your argument are valid. ;-)

So, it's as you wish on that topic !
But if we go in that direction, you should rewrite some readme files, because some part are obsolete / wrong now.

florian-dacosta · 2023-04-18T15:30:09Z

Thanks @legalsylvain I always forget to check the readme files...
I've updated it the readme file and I also added the possibility to add a custom domain in the cron, because we have a use case where we'd like the analysis to run on uninstalled modules. (I will allow to know the "cost" of your module before installing it...)

legalsylvain · 2023-04-18T15:32:51Z

module_analysis/readme/CONFIGURE.rst


-* Check the box 'Analyse Installed modules'
+* Run manually the action : 'Update Module Analysis'

    .. image:: ../static/description/base_module_update.png


I guess that line has to be removed. (and the according png file).

I've added the line => To run an update manually, you can run the scheduled action manually.
The image is indeed to remove

legalsylvain · 2023-04-18T15:33:38Z

(I will allow to know the "cost" of your module before installing it...)

good idea !

… cron. Usefull if we want to analyse the code for uninstalled modules for instance

PierrickBrun

looks good, I tested it in a customer project and the analysis worked well

florian-dacosta · 2023-05-16T08:28:36Z

@legalsylvain
Would you mind updating your review ?

legalsylvain

Thanks !

/ocabot merge nobump

OCA-git-bot · 2023-05-16T09:49:51Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2023-05-16T09:50:22Z

Sorry @legalsylvain you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

bguillot · 2023-05-16T11:13:33Z

/ocabot merge nobump

bguillot · 2023-05-16T11:13:48Z

Thanks !

OCA-git-bot · 2023-05-16T11:17:24Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2609-by-bguillot-bump-nobump, awaiting test results.

OCA-git-bot · 2023-05-16T11:32:48Z

Congratulations, your PR was merged at c0064d6. Thanks a lot for contributing to OCA. ❤️

legalsylvain and others added 28 commits April 18, 2023 14:38

Added translation using Weblate (Chinese (Simplified))

069195e

[IMP] module_analysis: black, isort, prettier

8fc7d87

[MIG] module_analysis: Migration to 13.0

cc4894b

Fix pre-commit warnings

114f1d7

fixup! Fix pre-commit warnings

8a422e2

Skip _test modules from test_installed_modules

3801a10

Remove anonymous variable _

0e150a8

fixup! [MIG] module_analysis: Migration to 13.0

28b5cc1

[Fix] author_txt_list assign

973efc9

Fix _get_files_to_analyse

d5882d6

Added translation using Weblate (Italian)

a94b015

Translated using Weblate (Italian)

adb259a

Currently translated at 100.0% (35 of 35 strings) Translation: server-tools-13.0/server-tools-13.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-module_analysis/it/

[FIX] module_analysis: correct syntax

34264f8

[MIG] module_analysis: Migration to 15.0

acdd3c2

[MIG] module_analysis: Migration to 15.0

[FIX+IMP] module_analysis : remove analysis when updating modules, be…

deabde4

…cause the analysis is partial (it also make the update slower) ; Add instead a cron task that is executed nightly to update analysis automatically

[UPD] Update module_analysis.pot

65fd04e

[UPD] README.rst

59bf048

Translated using Weblate (Italian)

91a14dc

Currently translated at 97.2% (35 of 36 strings) Translation: server-tools-15.0/server-tools-15.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-module_analysis/it/

[IMP] module_analysis: black, isort, prettier

3f24a0c

[16.0][MIG] module_analysis : migrate to 16

8adb4c0

[IMP] Remove automatic analyse at installation and update

e4e22e0

Analyse can take some time and a cron task can do it every day if needed, no need to recompute it in real time

[IMP] Add SCSS SLOC measure

394ea04

[FIX] fix usage of cron data, deactivate it by default

8e5457e

[REF] module_analysis: add legalsylvain as maintainers

536fdc1

[FIX] test: proper analysis before testing

520cc67

[FIX] Playing test after install must not be mandatory anymore becaus…

1416e8d

…e there is no post install hook anymore

florian-dacosta force-pushed the 16.0-mig-module_analysis branch from 9997e77 to 1416e8d Compare April 18, 2023 14:52

legalsylvain reviewed Apr 18, 2023

View reviewed changes

florian-dacosta added 2 commits April 18, 2023 17:39

module_analysis : Update readme

3d2fe98

[IMP] module_analysis : allow to pass a custom domain to the analysis…

bb94bdf

… cron. Usefull if we want to analyse the code for uninstalled modules for instance

florian-dacosta force-pushed the 16.0-mig-module_analysis branch from 9e6bce0 to bb94bdf Compare April 18, 2023 15:40

PierrickBrun approved these changes May 9, 2023

View reviewed changes

legalsylvain approved these changes May 16, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels May 16, 2023

OCA-git-bot added the bot is merging ⏳ label May 16, 2023

OCA-git-bot merged commit f90e1b6 into OCA:16.0 May 16, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 16, 2023

thomaspaulb mentioned this pull request Feb 23, 2024

[12.0][IMP] module_analysis: Remove automatic analyse at installation and update #2858

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16][MIG ] module_analysis #2609

[16][MIG ] module_analysis #2609

florian-dacosta commented Apr 18, 2023 •

edited

Loading

florian-dacosta commented Apr 18, 2023

legalsylvain commented Apr 18, 2023

florian-dacosta commented Apr 18, 2023

legalsylvain Apr 18, 2023

florian-dacosta Apr 18, 2023

legalsylvain commented Apr 18, 2023

PierrickBrun left a comment

florian-dacosta commented May 16, 2023

legalsylvain left a comment

OCA-git-bot commented May 16, 2023

OCA-git-bot commented May 16, 2023

bguillot commented May 16, 2023

bguillot commented May 16, 2023

OCA-git-bot commented May 16, 2023

OCA-git-bot commented May 16, 2023

[16][MIG ] module_analysis #2609

[16][MIG ] module_analysis #2609

Conversation

florian-dacosta commented Apr 18, 2023 • edited Loading

florian-dacosta commented Apr 18, 2023

legalsylvain commented Apr 18, 2023

florian-dacosta commented Apr 18, 2023

legalsylvain Apr 18, 2023

Choose a reason for hiding this comment

florian-dacosta Apr 18, 2023

Choose a reason for hiding this comment

legalsylvain commented Apr 18, 2023

PierrickBrun left a comment

Choose a reason for hiding this comment

florian-dacosta commented May 16, 2023

legalsylvain left a comment

Choose a reason for hiding this comment

OCA-git-bot commented May 16, 2023

OCA-git-bot commented May 16, 2023

bguillot commented May 16, 2023

bguillot commented May 16, 2023

OCA-git-bot commented May 16, 2023

OCA-git-bot commented May 16, 2023

florian-dacosta commented Apr 18, 2023 •

edited

Loading