[12.0][IMP] module_analysis: Remove automatic analyse at installation and update #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaspaulb
force-pushed
the
12.0-module_analysis-remove_hook
branch
from
61030f4
to
db0f3b2
Compare
|
Thanks for the backport. The cron is missing. Could you add it ? |
Analyse can take some time and a cron task can do it every day if needed, no need to recompute it in real time
…cause the analysis is partial (it also make the update slower) ; Add instead a cron task that is executed nightly to update analysis automatically
thomaspaulb
force-pushed
the
12.0-module_analysis-remove_hook
branch
from
db0f3b2
to
a6fb9d4
Compare
|
@legalsylvain Done, I had to cherry-pick a couple of other ones as well. |
thomaspaulb
changed the title
|
Looks like the other PR already got enough positive reviews, so I'll merge this. /ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 37afab9. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analyse can take some time and a cron task can do it every day if needed, no need to recompute it in real time.
Backport from:
#2609
commit
(main motivation, tests take ages without this mod - tests took 20+ mins, now 8mins)