[16][MIG ] module_analysis #2608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup! [ADD] new module module_analysis fixup! fixup! [ADD] new module module_analysis fixup! fixup! fixup! [ADD] new module module_analysis fixup! fixup! fixup! fixup! [ADD] new module module_analysis IMP exception message fixup! fixup! fixup! fixup! fixup! [ADD] new module module_analysis [REF] remove use of cloc. use pygount librairy instead fixup! [REF] remove use of cloc. use pygount librairy instead fixup! fixup! [REF] remove use of cloc. use pygount librairy instead Apply suggestions from code review Co-Authored-By: David Beal <david.beal@akretion.com> Update module_analysis/views/menu.xml Co-Authored-By: David Beal <david.beal@akretion.com> Update module_analysis/tests/test_module.py Co-Authored-By: David Beal <david.beal@akretion.com> Update module_analysis/readme/CONFIGURE.rst Co-Authored-By: David Beal <david.beal@akretion.com> [IMP] handle encoding [UPD] Update module_analysis.pot [UPD] README.rst [UPD] README.rst
Currently translated at 100.0% (35 of 35 strings) Translation: server-tools-12.0/server-tools-12.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-module_analysis/zh_CN/ [UPD] README.rst
Currently translated at 100.0% (35 of 35 strings) Translation: server-tools-13.0/server-tools-13.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-13-0/server-tools-13-0-module_analysis/it/
[MIG] module_analysis: Migration to 15.0
…cause the analysis is partial (it also make the update slower) ; Add instead a cron task that is executed nightly to update analysis automatically
Currently translated at 97.2% (35 of 36 strings) Translation: server-tools-15.0/server-tools-15.0-module_analysis Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-module_analysis/it/
Analyse can take some time and a cron task can do it every day if needed, no need to recompute it in real time
…e there is no post install hook anymore
In general I prefer all cron to be unactive at installation, mainly this kind of cron that you have to do some configuration (better change the time to run it at night at least, etc). It does not change a lot to unactivate it because you have to configure it anyway.
I went a bit too fast with the cherry-pick, I guess the second line could stay the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.