Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] mail_improved_tracking_value: migration to Odoo 11 #254

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions mail_improved_tracking_value/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3

==============================
Tracking value change improved
==============================

This module extends the mail_tracking_value functionality that records
value changes on predefined fields.
It adds support for many2many and one2many fields, which are not handled
well by default.
It also implements a new view (little bit more user friendly than the
existing one) to watch for changes

Installation
============

To install this module, you need to:

#. Just install the module

Configuration
=============

To configure this module, you need to:

# No configuration is necessary

Usage
=====

To access the new view displaying value changes :

Settings -> Technical -> Improved tracking values


Known issues / Roadmap
======================

* Improve rendering of values depending of type using qweb widgets

Bug Tracker
===========

Bugs are tracked on `GitHub Issues
<https://github.com/OCA/mail_improved_tracking_value/issues>`_. In case of trouble, please
check there if your issue has already been reported. If you spotted it first,
help us smash it by providing detailed and welcomed feedback.

Credits
=======

Images
------

* Odoo Community Association: `Icon <https://github.com/OCA/maintainer-tools/blob/master/template/module/static/description/icon.svg>`_.

Contributors
------------

* Thierry Ducrest <thierry.ducrest@camptocamp.com>

Maintainer
----------

.. image:: https://odoo-community.org/logo.png
:alt: Odoo Community Association
:target: https://odoo-community.org

This module is maintained by the OCA.

OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

To contribute to this module, please visit https://odoo-community.org.
4 changes: 4 additions & 0 deletions mail_improved_tracking_value/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Copyright 2018 Camptocamp SA
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

from . import models
20 changes: 20 additions & 0 deletions mail_improved_tracking_value/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Copyright 2018 Camptocamp SA
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

{
'name': 'Improved tracking value change',
'version': '11.0.1.0.0',
'summary': 'Improves tracking changed values for certain type of fields.'
'Adds a user-friendly view to consult them.',
'author': 'Camptocamp, Odoo Community Association (OCA)',
'license': 'AGPL-3',
'category': 'Tools',
'website': 'https://github.com/OCA/social',
'depends': [
'base',
'mail'
],
'data': [
'views/mail_tracking_value.xml'
],
}
5 changes: 5 additions & 0 deletions mail_improved_tracking_value/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# -*- coding: utf-8 -*-
# Copyright 2017 Camptocamp SA
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

from . import mail_tracking_value
85 changes: 85 additions & 0 deletions mail_improved_tracking_value/models/mail_tracking_value.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
# Copyright 2018 Camptocamp SA
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

import json

from odoo import api, fields, models


class MailTrackingValue(models.Model):

_inherit = "mail.tracking.value"

new_value_formatted = fields.Char(
compute='_compute_formatted_value',
string='New value',
)
old_value_formatted = fields.Char(
compute='_compute_formatted_value',
string='Old value',
)
record_name = fields.Char(
related='mail_message_id.record_name',
)
model = fields.Char(
related='mail_message_id.model',
store='True',
string='Model',
)

@api.depends('new_value_char', 'new_value_integer', 'new_value_float',
'new_value_text', 'new_value_datetime', 'new_value_monetary',
'old_value_char', 'old_value_integer', 'old_value_float',
'old_value_text', 'old_value_datetime', 'old_value_monetary')
def _compute_formatted_value(self):
""" Sets the value formatted field used in the view """
for record in self:
if record.field_type in ('many2many', 'one2many', 'char'):
record.new_value_formatted = record.new_value_char
record.old_value_formatted = record.old_value_char
elif record.field_type == 'integer':
record.new_value_formatted = str(record.new_value_integer)
record.old_value_formatted = str(record.old_value_integer)
elif record.field_type == 'float':
record.new_value_formatted = str(record.new_value_float)
record.old_value_formatted = str(record.old_value_float)
elif record.field_type == 'monetary':
record.new_value_formatted = str(record.new_value_monetary)
record.old_value_formatted = str(record.old_value_monetary)
elif record.field_type == 'datetime':
record.new_value_formatted = str(record.new_value_datetime)
record.old_value_formatted = str(record.old_value_datetime)
elif record.field_type == 'text':
record.new_value_formatted = record.new_value_text
record.old_value_formatted = record.old_value_text

@api.model
def create_tracking_values(self, old_value, new_value, col_name, col_info):
""" Add tacking capabilities for many2many and one2many fields """
if col_info['type'] in ('many2many', 'one2many'):

def get_values(source, prefix):
if source:
names = ', '.join(source.mapped('display_name'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
names = ', '.join(source.mapped('display_name'))
names = ', '.join(
[s.display_name for s in source.exists()])

If you do this, you avoid the Missing Record error for one2many, but then the message doesn't show the deleted record 😕

json_ids = json.dumps(source.ids)
else:
names = ''
json_ids = json.dumps([])
return {
'{}_value_char'.format(prefix): names,
'{}_value_text'.format(prefix): json_ids,
}

values = {
'field': col_name,
'field_desc': col_info['string'],
'field_type': col_info['type'],
}
values.update(get_values(old_value, 'old'))
values.update(get_values(new_value, 'new'))
return values
else:
return super().create_tracking_values(
old_value, new_value,
col_name, col_info
)
70 changes: 70 additions & 0 deletions mail_improved_tracking_value/views/mail_tracking_value.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>

<record id="tracking_change_list" model="ir.ui.view">
<field name="name">Tracking change list"</field>
<field name="model">mail.tracking.value</field>
<field name="arch" type="xml">
<tree string="Tracking change list" default_order="create_date desc"
create="false" edit="false" delete="false">
<field name="create_date" string="On"/>
<field name="record_name" string="For"/>
<field name="field_desc" string="Field changed"/>
<field name="old_value_formatted"/>
<field name="new_value_formatted"/>
<field name="model"/>
</tree>
</field>
</record>

<record id="tracking_change_form_view" model="ir.ui.view">
<field name="name">Tracking change form</field>
<field name="model">mail.tracking.value</field>
<field name="priority" eval="20"/>
<field name="arch" type="xml">
<form>
<sheet>
<field name="create_date" class="oe-inline"/>
<group name="main">
<field name="mail_message_id" string="For"/>
<field name="field_desc" string="Field changed"/>
<field name="old_value_formatted"/>
<field name="new_value_formatted"/>
<field name="model"/>
</group>
</sheet>
</form>
</field>
</record>

<record id="tracking_change_list_filter" model="ir.ui.view">
<field name="name">Tracking change list filter</field>
<field name="model">mail.tracking.value</field>
<field name="arch" type="xml">
<search string="Search">
<field name="model"/>
<group expand="1" string="Group By">
<filter name="model" string="Model" context="{'group_by':'model'}"/>
</group>
</search>
</field>
</record>

<record id="action_view_tracking_changes" model="ir.actions.act_window">
<field name="name">View last tracked changes</field>
<field name="res_model">mail.tracking.value</field>
<field name="view_mode">tree,form</field>
<field name="view_ids" eval="[(5, 0, 0),
(0, 0, {'view_mode': 'tree', 'view_id': ref('tracking_change_list')}),
(0, 0, {'view_mode': 'form', 'view_id': ref('tracking_change_form_view')})]"
/>
</record>

<menuitem action="action_view_tracking_changes"
id ="menu_action_view_tracking_changes"
name="Improved Tracking Values"
parent="base.menu_email"
sequence="10"
/>

</odoo>