-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] stock_barcodes: Migration to v13.0 #252
Conversation
577817e
to
d72c480
Compare
Please cherry-pick 3f6c541 |
Ok. Done |
8074aa3
to
eb0802f
Compare
Please don't add merge commits that breaks future commit history preservation. Anyway, Travis is red. |
When user creates a lot, set default product the wizard selected product. When confirm the lot creation wizard, set this lot in lot wizard scanning barcode field.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-barcode-11.0/stock-logistics-barcode-11.0-stock_barcodes Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-11-0/stock-logistics-barcode-11-0-stock_barcodes/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-stock_barcodes Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-stock_barcodes/
When we've got an out picking, the logical workflow is that the scanned location is the location we're getting the stock from
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-stock_barcodes Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-stock_barcodes/
7792f47
to
53bc0a1
Compare
53bc0a1
to
6fca995
Compare
@pedrobaeza Ready!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on runbot 👍
@@ -1,5 +1,5 @@ | |||
.oe_stock_scan_image_btn { | |||
/*height : 42px;*/ | |||
/*height : 42px;*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can go away, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review, tested on local 👍
6fca995
to
3f89eb9
Compare
@chienandalu removed unused class |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at afa3a27. Thanks a lot for contributing to OCA. ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a multi company problem.
return { | ||
"product_id": self.product_id.id, | ||
"name": self.lot_name, | ||
"company_id": self.env.user.company_id.id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting company from the user causes problems since this is the default company, not the current company. Perhaps it should be defined here and default is passed from calling document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good catch. It should be self.env.company.id
AFAIK. Can you do the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe the company from the picking if locked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am busy right now working on mrp_barcodes module :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergio-teruel can you please check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@levkar eagering to see mrp_barcodes 😉
TT22175