Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] stock_barcodes: Migration to v13.0 #252

Merged
merged 23 commits into from
Apr 16, 2020

Conversation

sergio-teruel
Copy link
Contributor

TT22175

@chienandalu
Copy link
Member

Please cherry-pick 3f6c541

@sergio-teruel
Copy link
Contributor Author

Ok. Done

@pedrobaeza
Copy link
Member

Please don't add merge commits that breaks future commit history preservation. Anyway, Travis is red.

sergio-teruel and others added 22 commits April 14, 2020 21:57
When user creates a lot, set default product the wizard selected product.
When confirm the lot creation wizard, set this lot in lot wizard scanning barcode field.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-11.0/stock-logistics-barcode-11.0-stock_barcodes
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-11-0/stock-logistics-barcode-11-0-stock_barcodes/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-stock_barcodes
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-stock_barcodes/
When we've got an out picking, the logical workflow is that the scanned location
is the location we're getting the stock from
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-stock_barcodes
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-stock_barcodes/
@sergio-teruel
Copy link
Contributor Author

@pedrobaeza Ready!!

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot 👍

@@ -1,5 +1,5 @@
.oe_stock_scan_image_btn {
/*height : 42px;*/
/*height : 42px;*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can go away, isn't it?

Copy link

@JoanSForgeFlow JoanSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, tested on local 👍

@sergio-teruel
Copy link
Contributor Author

@chienandalu removed unused class

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-252-by-pedrobaeza-bump-nobump, awaiting test results.

@pedrobaeza pedrobaeza changed the title [WIP][MIG][13.0] stock_barcodes: Migration to v13.0 [13.0][MIG] stock_barcodes: Migration to v13.0 Apr 16, 2020
@OCA-git-bot OCA-git-bot merged commit aa510cc into OCA:13.0 Apr 16, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at afa3a27. Thanks a lot for contributing to OCA. ❤️

Copy link

@levkar levkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a multi company problem.

return {
"product_id": self.product_id.id,
"name": self.lot_name,
"company_id": self.env.user.company_id.id,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting company from the user causes problems since this is the default company, not the current company. Perhaps it should be defined here and default is passed from calling document.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch. It should be self.env.company.id AFAIK. Can you do the PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe the company from the picking if locked.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am busy right now working on mrp_barcodes module :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergio-teruel can you please check?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levkar eagering to see mrp_barcodes 😉

@pedrobaeza pedrobaeza deleted the 13.0-mig-stock_barcodes branch May 2, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants