Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][13.0] stock_barcodes_gs1: Migration to v13.0 #254

Merged
merged 12 commits into from
Jul 26, 2020
Merged

[MIG][13.0] stock_barcodes_gs1: Migration to v13.0 #254

merged 12 commits into from
Jul 26, 2020

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel commented Feb 13, 2020 •
edited
Loading

TT22177

@sergio-teruel sergio-teruel mentioned this pull request Apr 9, 2020
Closed
@jimhoefnagels
Copy link

The dependency is merged, so rebasing and running pre-commit should fix the errors.

@sergio-teruel
Copy link
Contributor Author

Sorry @jimhoefnagels stock_barcodes module is still open...
#252

@AaronHForgeFlow
Copy link

#252 is merged 🎉 could you rebase?

@rousseldenis rousseldenis added this to the 13.0 milestone Apr 30, 2020
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 30, 2020
Closed
9 tasks
@sergio-teruel
Copy link
Contributor Author

@AaronHForgeFlow rebase done!!

oca-travis and others added 12 commits June 24, 2020 16:28
@oca-travis @sergio-teruel
[ADD] stock_barcodes_gs1: Add support to stock_barcodes module to rea…
d428bcf 
…d GS1 barcodes
@oca-travis @sergio-teruel
[UPD] Update stock_barcodes_gs1.pot
d9aba36
@OCA-git-bot @sergio-teruel
[UPD] README.rst
913b738
@JordiBForgeFlow @sergio-teruel
Sometimes the product does not yet have a GTIN. In this case
c82d4f4 
try the AI 240 'Additional product identification assigned
by the manufacturer'
@oca-travis @sergio-teruel
[UPD] Update stock_barcodes_gs1.pot
1f1c567
@OCA-git-bot @sergio-teruel
stock_barcodes_gs1 11.0.1.0.1
5b11bab
@oca-transbot @sergio-teruel
Update translation files
96a576f 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-barcode-11.0/stock-logistics-barcode-11.0-stock_barcodes_gs1
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-11-0/stock-logistics-barcode-11-0-stock_barcodes_gs1/
@JoanSForgeFlow @sergio-teruel
[MIG] stock_barcodes_gs1: Migration to 12.0
8ac29bb
@oca-travis @sergio-teruel
[UPD] Update stock_barcodes_gs1.pot
cbf0ee0
@OCA-git-bot @sergio-teruel
[UPD] README.rst
e181527
@sergio-teruel
[IMP] stock_barcodes_gs1: black, isort
6a79e70
@sergio-teruel
[MIG] stock_barcodes_gs1: Migration to v13.0
568fc87
@sergio-teruel
Copy link
Contributor Author

Ready!!

@sergio-teruel
Copy link
Contributor Author

@carlosdauden @chienandalu CAn you review... please??

@sergio-teruel sergio-teruel mentioned this pull request Jul 17, 2020
Merged
chienandalu
chienandalu approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot and code review 👍

rafaelbn
rafaelbn approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks

@pedrobaeza
Copy link
Member

Is this still WIP?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sergio-teruel sergio-teruel changed the title [WIP][MIG][13.0] stock_barcodes_gs1: Migration to v13.0 [MIG][13.0] stock_barcodes_gs1: Migration to v13.0 Jul 21, 2020
@sergio-teruel
Copy link
Contributor Author

@pedrobaeza ready!!

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-254-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 21, 2020
@OCA-git-bot
Merge PR #254 into 13.0
5706df9 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-254-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

OCA-git-bot added a commit that referenced this pull request Jul 26, 2020
@OCA-git-bot
Merge PR #254 into 13.0
8e48a7f 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-254-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-254-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-254-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 85facee into OCA:13.0 Jul 26, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 359c416. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@chienandalu chienandalu chienandalu approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.