Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] stock_barcodes_gs1_expiry #270

Merged

Conversation

jimhoefnagels
Copy link

No description provided.

@jimhoefnagels jimhoefnagels force-pushed the 13.0-mig-stock_barcodes_gs1_expiry branch 2 times, most recently from 79bd51f to 5150cda Compare April 9, 2020 11:40
@jimhoefnagels jimhoefnagels changed the title 13.0 mig stock barcodes gs1 expiry [13.0][MIG] stock_barcodes_gs1_expiry Apr 9, 2020
@jimhoefnagels jimhoefnagels force-pushed the 13.0-mig-stock_barcodes_gs1_expiry branch 3 times, most recently from d6b15ec to 78767ca Compare April 14, 2020 09:47
@rousseldenis rousseldenis added this to the 13.0 milestone Apr 14, 2020
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 14, 2020
9 tasks
@sergio-teruel
Copy link
Contributor

@jimhoefnagels Can you rebase from 13.0 to solve conflicts??

@@ -0,0 +1,2 @@
stock-logistics-barcode https://github.com/Tecnativa/stock-logistics-barcode 13.0-mig-stock_barcodes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this module already merged

@@ -0,0 +1,2 @@
stock-logistics-barcode https://github.com/Tecnativa/stock-logistics-barcode 13.0-mig-stock_barcodes
stock-logistics-barcode-2 https://github.com/Tecnativa/stock-logistics-barcode 13.0-mig-stock_barcodes_gs1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is #254

@jimhoefnagels jimhoefnagels force-pushed the 13.0-mig-stock_barcodes_gs1_expiry branch from 78767ca to ad251db Compare July 30, 2020 08:51
@jimhoefnagels jimhoefnagels force-pushed the 13.0-mig-stock_barcodes_gs1_expiry branch from ad251db to 6288bfb Compare July 30, 2020 09:17
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major changes

Copy link

@albariera albariera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@etobella
Copy link
Member

@sergio-teruel All changes have been applied

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-270-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ed7b1e9 into OCA:13.0 May 17, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 96611a9. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants