Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] barcodes_generator_abstract: Migration to 14.0 #340

Merged
merged 18 commits into from
Aug 17, 2021

Conversation

Zar21
Copy link
Contributor

@Zar21 Zar21 commented May 19, 2021

Superseeds #313

@Zar21 Zar21 force-pushed the 14.0-mig-barcodes_generator_abstract branch 2 times, most recently from f479d93 to 9a4e657 Compare May 19, 2021 11:08
legalsylvain and others added 16 commits May 19, 2021 13:19
* Rename manifest
* Change openerp references to odoo
* Bump version
* Alphabetize imports
* pyBarcode is no longer maintained, switch to viivakoodi fork (https://bitbucket.org/whitie/python-barcode/issues/16/pypi-08-release-request#comment-33978213)
)

Add an option to allow for automatic generation of barcode when a record of mixin model is created
* [FIX] barcodes_generator_abstract: Caching issue
* Make cache method return ids & move the recordset method out of cache to fix OCA#93
Currently translated at 29.6% (8 of 27 strings)

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_abstract
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_abstract/de/
Currently translated at 14.8% (4 of 27 strings)

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_abstract
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_abstract/sl/
Currently translated at 46.4% (13 of 28 strings)

Translation: stock-logistics-barcode-12.0/stock-logistics-barcode-12.0-barcodes_generator_abstract
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-barcode-12-0/stock-logistics-barcode-12-0-barcodes_generator_abstract/it/
Copy link

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugho-ad
Copy link
Contributor

LGTM 👍

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-340-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Aug 17, 2021
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command oca-gen-addon-readme --org-name OCA --repo-name stock-logistics-barcode --branch 14.0 --addons-dir /tmp/tmpoaoy54ee --commit failed with output:

/tmp/tmpoaoy54ee/barcodes_generator_abstract/README.rst:141: (SEVERE/4) Title level inconsistent:

Note
~~~~
Traceback (most recent call last):
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 349, in check_subsection
    level = title_styles.index(style) + 1
ValueError: '~' is not in list

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/oca-gen-addon-readme", line 11, in <module>
    load_entry_point('oca-maintainers-tools', 'console_scripts', 'oca-gen-addon-readme')()
  File "/ocamt-readme/lib/python3.8/site-packages/click/core.py", line 1137, in __call__
    return self.main(*args, **kwargs)
  File "/ocamt-readme/lib/python3.8/site-packages/click/core.py", line 1062, in main
    rv = self.invoke(ctx)
  File "/ocamt-readme/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/ocamt-readme/lib/python3.8/site-packages/click/core.py", line 763, in invoke
    return __callback(*args, **kwargs)
  File "/ocamt-readme/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 312, in gen_addon_readme
    check_rst(readme_filename)
  File "/ocamt-readme/src/oca-maintainers-tools/tools/gen_addon_readme.py", line 239, in check_rst
    publish_file(
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/core.py", line 370, in publish_file
    output, pub = publish_programmatically(
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/core.py", line 664, in publish_programmatically
    output = pub.publish(enable_exit_status=enable_exit_status)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/core.py", line 216, in publish
    self.document = self.reader.read(self.source, self.parser,
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/readers/__init__.py", line 71, in read
    self.parse()
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/readers/__init__.py", line 77, in parse
    self.parser.parse(self.input, document)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/__init__.py", line 191, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 170, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/statemachine.py", line 238, in run
    context, next_state, result = self.check_line(
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/statemachine.py", line 460, in check_line
    return method(match, context, next_state)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 3007, in text
    self.section(title.lstrip(), source, style, lineno + 1, messages)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 327, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 393, in new_subsection
    newabsoffset = self.nested_parse(
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 281, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 196, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/statemachine.py", line 238, in run
    context, next_state, result = self.check_line(
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/statemachine.py", line 460, in check_line
    return method(match, context, next_state)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2771, in underline
    self.section(title, source, style, lineno - 1, messages)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 327, in section
    self.new_subsection(title, lineno, messages)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 393, in new_subsection
    newabsoffset = self.nested_parse(
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 281, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 196, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/statemachine.py", line 238, in run
    context, next_state, result = self.check_line(
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/statemachine.py", line 460, in check_line
    return method(match, context, next_state)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2771, in underline
    self.section(title, source, style, lineno - 1, messages)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 326, in section
    if self.check_subsection(source, style, lineno):
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 355, in check_subsection
    self.parent += self.title_inconsistent(source, lineno)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 371, in title_inconsistent
    error = self.reporter.severe(
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/utils/__init__.py", line 237, in severe
    return self.system_message(self.SEVERE_LEVEL, *args, **kwargs)
  File "/ocamt-readme/lib/python3.8/site-packages/docutils/utils/__init__.py", line 195, in system_message
    raise SystemMessage(msg, level)
docutils.utils.SystemMessage: /tmp/tmpoaoy54ee/barcodes_generator_abstract/README.rst:141: (SEVERE/4) Title level inconsistent:

Note
~~~~

barcodes_generator_abstract/i18n/es_ES.po Outdated Show resolved Hide resolved
barcodes_generator_abstract/readme/USAGE.rst Outdated Show resolved Hide resolved
Zar21 and others added 2 commits August 17, 2021 08:29
Improve form view of barcode rules
Improve README
Auto-add admin to the group
@Zar21 Zar21 force-pushed the 14.0-mig-barcodes_generator_abstract branch from ee6c8aa to fcadcb4 Compare August 17, 2021 06:32
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-340-by-pedrobaeza-bump-nobump, awaiting test results.

@pedrobaeza pedrobaeza mentioned this pull request Aug 17, 2021
15 tasks
@OCA-git-bot OCA-git-bot merged commit 28c576e into OCA:14.0 Aug 17, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 87fa61e. Thanks a lot for contributing to OCA. ❤️

@francesco-ooops
Copy link
Contributor

francesco-ooops commented Oct 4, 2022

@legalsylvain could you find a way to get the readme file regenerated? image urls are broken (while they're not in "configuration" file)

thanks :)

@legalsylvain
Copy link
Contributor

Image path is bad.you should set "../static/"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.