Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] fs_attachment: Avoid error on url compute #302

Merged
merged 1 commit into from
Nov 22, 2023
Merged

[16.0][FIX] fs_attachment: Avoid error on url compute #302

merged 1 commit into from
Nov 22, 2023

Conversation

lmignon
Copy link
Contributor

@lmignon lmignon commented Nov 22, 2023

Avoid error when the directory_path is not set on the storage when computing the attachement

@lmignon
[FIX] fs_attachment: Avoid error on url compute
24a270f 
Avoid error when the directory_path is not set on the storage when computing the attachement
@lmignon lmignon force-pushed the 16.0-fix-attachment-url-build branch from b7df0c3 to 24a270f Compare November 22, 2023 17:41
@lmignon
Copy link
Contributor Author

lmignon commented Nov 22, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-302-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@lmignon The merge process could not be finalized, because command git push origin 16.0-ocabot-merge-pr-302-by-lmignon-bump-patch:16.0 failed with output:

To https://github.com/OCA/storage
 ! [remote rejected] 16.0-ocabot-merge-pr-302-by-lmignon-bump-patch -> 16.0 (cannot lock ref 'refs/heads/16.0': is at 53941ea6619c43fbca62b5cfc996ce0d53f824dd but expected 8ef48f273efe231b9322bb98f949b45594c48bc3)
error: failed to push some refs to 'https://***@github.com/OCA/storage'

@OCA-git-bot OCA-git-bot merged commit c50cad5 into OCA:16.0 Nov 22, 2023
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 53941ea. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-fix-attachment-url-build branch November 22, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmignon @OCA-git-bot