Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][MIG] hr_timesheet_sheet_attendance #199

Merged
merged 5 commits into from
Jun 12, 2020
Merged

[12.0][MIG] hr_timesheet_sheet_attendance #199

merged 5 commits into from
Jun 12, 2020

Conversation

naglis
Copy link
Contributor

@naglis naglis commented Mar 4, 2019

No description provided.

@pedrobaeza pedrobaeza added this to the 12.0 milestone Mar 4, 2019
@naglis naglis mentioned this pull request Mar 4, 2019
Closed
9 tasks
@pedrobaeza pedrobaeza mentioned this pull request Mar 7, 2019
Closed
bizzappdev
bizzappdev approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@bizzappdev bizzappdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tbaden
tbaden suggested changes May 20, 2019
View reviewed changes
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
I did a code review: just some minor change and some optional if you like.

hr_timesheet_sheet_attendance/__manifest__.py Outdated Show resolved Hide resolved
hr_timesheet_sheet_attendance/__manifest__.py Outdated Show resolved Hide resolved
hr_timesheet_sheet_attendance/views/hr_attendance_view.xml Outdated Show resolved Hide resolved
hr_timesheet_sheet_attendance/views/hr_attendance_view.xml Outdated Show resolved Hide resolved
hr_timesheet_sheet_attendance/views/hr_timesheet_sheet_view.xml Outdated Show resolved Hide resolved
hr_timesheet_sheet_attendance/views/hr_timesheet_sheet_view.xml Outdated Show resolved Hide resolved
hr_timesheet_sheet_attendance/views/hr_timesheet_sheet_view.xml Outdated Show resolved Hide resolved
@naglis naglis force-pushed the 12.0-mig-hr_timesheet_sheet_attendance branch from dbe0a18 to 8e7898b Compare May 22, 2019 09:23
@treviser
Copy link

treviser commented Jun 1, 2020

What is the actual status of this PR?

rafaelbn
rafaelbn approved these changes Jun 5, 2020
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+1 Thanksgiving

chienandalu
chienandalu approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!

@chienandalu
Copy link
Member

@tbaden Can you give your final blessing?

@tbaden
Copy link
Member

tbaden commented Jun 12, 2020

LGTM

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 12.0-ocabot-merge-pr-199-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit f341ae3 into OCA:12.0 Jun 12, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 849384c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bizzappdev bizzappdev bizzappdev approved these changes

@chienandalu chienandalu chienandalu approved these changes

@tbaden tbaden tbaden approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@naglis @treviser @chienandalu @tbaden @pedrobaeza @OCA-git-bot @bizzappdev @rafaelbn @oca-travis