-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0][MIG] hr_timesheet_sheet_attendance #199
[12.0][MIG] hr_timesheet_sheet_attendance #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the work 👍
I did a code review: just some minor change and some optional if you like.
hr_timesheet_sheet_attendance/views/hr_timesheet_sheet_view.xml
Outdated
Show resolved
Hide resolved
hr_timesheet_sheet_attendance/views/hr_timesheet_sheet_view.xml
Outdated
Show resolved
Hide resolved
hr_timesheet_sheet_attendance/views/hr_timesheet_sheet_view.xml
Outdated
Show resolved
Hide resolved
dbe0a18
to
8e7898b
Compare
What is the actual status of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:+1 Thanksgiving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks!
@tbaden Can you give your final blessing? |
LGTM |
/ocabot merge nobump |
On my way to merge this fine PR! |
This PR has the |
Congratulations, your PR was merged at 849384c. Thanks a lot for contributing to OCA. ❤️ |
No description provided.