-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add module logistic_consignee #14
Conversation
yvaucher
commented
Oct 30, 2014
- extract consignee_id field from logistic_order
d0ca0bf
to
24c0822
Compare
d1fb0c7
to
16cdc32
Compare
@yvaucher travis is really behind today. Have you run the tests locally? they pass? |
Logistic Consignee | ||
================== | ||
|
||
This module customizes adds a consignee, the person to whom the shipment must |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
customizes
@lepistone I just splitted the tests as consignee is mandatory on sale order. And yes the test were green locally but of course without other modules installed. EDIT: pinging lepistone not lep |
@lepistone I'll refactor those tests |
c9951e0
to
de8f3f2
Compare
tests re-factored and few fixes done a tiny pep8 left |
6694513
to
cf73c58
Compare
rebased and pep8 fixed |
A couple non-blocking remarks remain, plus a mysterious red build. |
1228087
to
072f7c5
Compare
thanks 👍 |
👍 |
072f7c5
to
955501b
Compare
- extract consignee_id field from logistic_order
955501b
to
e83f78d
Compare
travis result is here https://travis-ci.org/OCA/vertical-ngo/builds/39608657 |
We need to run the unit tests for logistic_consignee separately from the rest because other modules in this repo will install purchase_rfq_bid_workflow and the unit tests of logistic_consignee create PO which are not in the correct workflow.
06f8525
to
9077b0d
Compare
👍 |
add module logistic_consignee
\o/ coveralls wakes up |