Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add module logistic_consignee #14

Merged
merged 10 commits into from Oct 31, 2014
Merged

add module logistic_consignee #14

merged 10 commits into from Oct 31, 2014

Conversation

yvaucher
Copy link
Member

  • extract consignee_id field from logistic_order

@yvaucher yvaucher force-pushed the 8.0-add-logistic_consignee branch 2 times, most recently from d0ca0bf to 24c0822 Compare October 30, 2014 15:31
@yvaucher yvaucher mentioned this pull request Oct 30, 2014
Merged
@yvaucher yvaucher force-pushed the 8.0-add-logistic_consignee branch 2 times, most recently from d1fb0c7 to 16cdc32 Compare October 30, 2014 16:18
@lepistone
Copy link
Member

@yvaucher travis is really behind today. Have you run the tests locally? they pass?

lepistone
lepistone reviewed Oct 30, 2014
View reviewed changes
logistic_consignee/README.rst
Logistic Consignee
==================

This module customizes adds a consignee, the person to whom the shipment must
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customizes

@yvaucher
Copy link
Member Author

@lepistone I just splitted the tests as consignee is mandatory on sale order.

And yes the test were green locally but of course without other modules installed.

EDIT: pinging lepistone not lep

@yvaucher
Copy link
Member Author

@lepistone I'll refactor those tests

@yvaucher
Copy link
Member Author

tests re-factored and few fixes done

a tiny pep8 left

@yvaucher
Copy link
Member Author

rebased and pep8 fixed

@lepistone
Copy link
Member

A couple non-blocking remarks remain, plus a mysterious red build.

@yvaucher yvaucher force-pushed the 8.0-add-logistic_consignee branch 4 times, most recently from 1228087 to 072f7c5 Compare October 31, 2014 10:35
@lepistone
Copy link
Member

thanks 👍

@gurneyalex
Copy link
Member

👍

@gurneyalex gurneyalex mentioned this pull request Oct 31, 2014
Merged
5 tasks
@yvaucher
Copy link
Member Author

travis result is here https://travis-ci.org/OCA/vertical-ngo/builds/39608657

@gurneyalex
correct travis config
9077b0d 
We need to run the unit tests for logistic_consignee separately from the rest
because other modules in this repo will install purchase_rfq_bid_workflow and
the unit tests of logistic_consignee create PO which are not in the correct
workflow.
@yvaucher
Copy link
Member Author

👍

lepistone added a commit that referenced this pull request Oct 31, 2014
@lepistone
Merge pull request #14 from yvaucher/8.0-add-logistic_consignee
5d27e3a 
add module logistic_consignee
@lepistone lepistone merged commit 5d27e3a into OCA:8.0 Oct 31, 2014
@yvaucher yvaucher deleted the 8.0-add-logistic_consignee branch October 31, 2014 21:42
@coveralls
Copy link

coveralls commented May 10, 2016 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 9077b0d on yvaucher:8.0-add-logistic_consignee into 01f8593 on OCA:8.0.

@yvaucher
Copy link
Member Author

yvaucher commented May 10, 2016 •
edited

\o/ coveralls wakes up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yvaucher @lepistone @gurneyalex @coveralls @pedrobaeza