Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] web_ir_actions_act_view_reload: Migration to 14.0 #1816

Merged
merged 17 commits into from
Aug 3, 2021
Merged

[MIG] web_ir_actions_act_view_reload: Migration to 14.0 #1816

merged 17 commits into from
Aug 3, 2021

Conversation

paidykumar-dreambits
Copy link

Migration from 13.0 to 14.0

pnajman-modoolar and others added 17 commits February 6, 2021 17:09
@pnajman-modoolar @paidykumar-dreambits
Contribution: add module web_ir_actions_act_view_reload
90d0506
@alexey-pelykh @paidykumar-dreambits
[MIG] web_ir_actions_act_view_reload: Migration to 12.0
c7608f7
@oca-travis @paidykumar-dreambits
[UPD] Update web_ir_actions_act_view_reload.pot
e7f57eb
@OCA-git-bot @paidykumar-dreambits
[UPD] README.rst
acdfe65
@guewen @paidykumar-dreambits
[IMP] web_ir_actions_act_view_reload: black, isort
30c9898
@guewen @paidykumar-dreambits
[MIG] web_ir_actions_act_view_reload: Migration to 13.0
d78af35
@guewen @paidykumar-dreambits
Switch license in js file to be aligned with manifest
eee36e4 
Ref: OCA#1462 (comment)
@oca-travis @paidykumar-dreambits
[UPD] Update web_ir_actions_act_view_reload.pot
f6df337
@OCA-git-bot @paidykumar-dreambits
[UPD] README.rst
8f147b4
@paidykumar-dreambits
[IMP] pre-commit run after update
e6bc911 
Includes some manual fixes to silent ESLint warnings.
@OCA-git-bot @paidykumar-dreambits
[UPD] README.rst
206f8a5
@OCA-git-bot @paidykumar-dreambits
[UPD] README.rst
90b6797
@KENLYLST @paidykumar-dreambits
web_ir_actions_act_view_reload: fix README (OCA#1633)
11961df 
Unresolved reference self and module odoo.api has no attribute multi
@OCA-git-bot @paidykumar-dreambits
[UPD] README.rst
c095bd6
@alexey-pelykh @paidykumar-dreambits
[UPD] Brainbean Apps => CorporateHub
78ac45d
@OCA-git-bot @paidykumar-dreambits
[UPD] README.rst
879a726
@paidykumar-dreambits
[MIG] web_ir_actions_act_view_reload: Migration to 14.0
71f6460
@paidykumar-dreambits paidykumar-dreambits mentioned this pull request Feb 6, 2021
Closed
34 tasks
@dzungtran89 dzungtran89 mentioned this pull request Feb 23, 2021
Merged
dsolanki-initos
dsolanki-initos reviewed Mar 17, 2021
View reviewed changes
Copy link
Contributor

@dsolanki-initos dsolanki-initos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per OCA guideline we need seperate commit for pre-commit you have added it in one commit.

Otherwise no major change.

@dsolanki-initos
Copy link
Contributor

Hi @paidykumar-dreambits PLease have a look at above comments and also ask some other contribuor to review. so that this PR will get merge soon.

@ygol ygol mentioned this pull request Apr 14, 2021
Merged
@dsolanki-initos
Copy link
Contributor

Hello @paidykumar-dreambits Can you please have a look at above comments and resolve it keeping the goal in mind to merge the PR.

@dsolanki-initos
Copy link
Contributor

Hi @paidykumar-dreambits It would be great if you can look at above comments.

@dsolanki-initos
Copy link
Contributor

It would be great if we could get the reviews here and Merge the PR ASAP.

1 similar comment
@dsolanki-initos
Copy link
Contributor

It would be great if we could get the reviews here and Merge the PR ASAP.

@dsolanki-initos
Copy link
Contributor

It would be great if maintainers could merge the PR since long it is ready.

1 similar comment
@dsolanki-initos
Copy link
Contributor

It would be great if maintainers could merge the PR since long it is ready.

rven
rven approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@rven rven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality tested and approved!

@rven
Copy link
Contributor

rven commented Jun 8, 2021

@dsolanki-initos maybe you could also approve the changes?
This way it gets the label approved...

dsolanki-initos
dsolanki-initos approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@dsolanki-initos dsolanki-initos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.Functional and Code Review.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dsolanki-initos
Copy link
Contributor

It would be great if the maintainers could merge the PR

2 similar comments
@dsolanki-initos
Copy link
Contributor

It would be great if the maintainers could merge the PR

@dsolanki-initos
Copy link
Contributor

It would be great if the maintainers could merge the PR

andreampiovesana
andreampiovesana approved these changes Jul 21, 2021
View reviewed changes
Copy link

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok
merge?

@mmequignon
Copy link
Member

ok
merge?

@simahawk ?

@simahawk simahawk changed the title 14.0 mig web ir actions act view reload [MIG] web_ir_actions_act_view_reload: Migration to 14.0 Aug 3, 2021
@simahawk
Copy link
Contributor

simahawk commented Aug 3, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-1816-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 205e1ed into OCA:14.0 Aug 3, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fe9bf21. Thanks a lot for contributing to OCA. ❤️

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rven rven rven approved these changes

@andreampiovesana andreampiovesana andreampiovesana approved these changes

@dsolanki-initos dsolanki-initos dsolanki-initos approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.