Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] web_ir_actions_act_view_reload: Migration to 13.0 #1462

Merged
merged 8 commits into from
Jan 8, 2020
Merged

[MIG] web_ir_actions_act_view_reload: Migration to 13.0 #1462

merged 8 commits into from
Jan 8, 2020

Conversation

guewen
Copy link
Member

@guewen guewen commented Dec 16, 2019

Port #1104

@OCA-git-bot OCA-git-bot mentioned this pull request Dec 16, 2019
Closed
41 tasks
@pedrobaeza pedrobaeza added this to the 13.0 milestone Dec 16, 2019
@guewen guewen mentioned this pull request Dec 18, 2019
Merged
@guewen guewen marked this pull request as ready for review December 18, 2019 10:25
guewen added a commit to guewen/web that referenced this pull request Dec 20, 2019
@guewen
Switch license in js file to be consistent with manifest
d119ae9 
Ref: OCA#1462 (comment)
@alexey-pelykh
Copy link
Contributor

@guewen I don't remember exactly, but promises look differently in v13, as far as I remember, so $.when() should be something else, but I'm not sure

@alexey-pelykh
Copy link
Contributor

Or was that Promise.resolve() changed to $.when()...

@guewen
Copy link
Member Author

guewen commented Jan 7, 2020 •
edited
Loading

@alexey-pelykh that's right, thanks! $.when() is replaced by Promise.resolve().

edit: added a note about this on https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0

simahawk
simahawk approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.
@guewen can you squash?
@alexey-pelykh can you pass by again?

guewen added a commit to guewen/web that referenced this pull request Jan 8, 2020
@guewen
Switch license in js file to be aligned with manifest
ff1ef4b 
Ref: OCA#1462 (comment)
@guewen guewen force-pushed the 13.0-mig-web_ir_actions_act_view_reload branch from 9e9b939 to ff1ef4b Compare January 8, 2020 08:36
@guewen guewen force-pushed the 13.0-mig-web_ir_actions_act_view_reload branch from ff1ef4b to 9a99cfc Compare January 8, 2020 08:45
@simahawk
Copy link
Contributor

simahawk commented Jan 8, 2020

@tarteo your comments have been addressed. We are good to merge.

@simahawk simahawk dismissed tarteo’s stale review January 8, 2020 10:21

comments addressed

@simahawk
Copy link
Contributor

simahawk commented Jan 8, 2020

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-1462-by-simahawk-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 8, 2020
@OCA-git-bot
Merge PR #1462 into 13.0
0679fac 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 9a99cfc into OCA:13.0 Jan 8, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0891579. Thanks a lot for contributing to OCA. ❤️

paidykumar-dreambits pushed a commit to paidykumar-dreambits/web that referenced this pull request Feb 6, 2021
@guewen @paidykumar-dreambits
Switch license in js file to be aligned with manifest
eee36e4 
Ref: OCA#1462 (comment)
NL66278 pushed a commit to NL66278/web that referenced this pull request Sep 14, 2021
@guewen @NL66278
Switch license in js file to be aligned with manifest
cdc0a65 
Ref: OCA#1462 (comment)
kimirondon pushed a commit to archeti-org/web that referenced this pull request Jul 4, 2022
@guewen
Switch license in js file to be aligned with manifest
4549997 
Ref: OCA#1462 (comment)
ryanc-me pushed a commit to ryanc-me/web that referenced this pull request Aug 9, 2022
@guewen @foodflo
Switch license in js file to be aligned with manifest
7e38c82 
Ref: OCA#1462 (comment)

[UPD] Update web_ir_actions_act_view_reload.pot

[UPD] README.rst
llabusch93 pushed a commit to archeti-org/web that referenced this pull request Sep 14, 2022
@guewen @llabusch93
Switch license in js file to be aligned with manifest
9a5c6e1 
Ref: OCA#1462 (comment)
heliaktiv pushed a commit to heliaktiv/oca-web that referenced this pull request Jun 1, 2023
@guewen @heliaktiv
Switch license in js file to be aligned with manifest
9056d02 
Ref: OCA#1462 (comment)

[UPD] Update web_ir_actions_act_view_reload.pot

[UPD] README.rst
adasatorres pushed a commit to adasatorres/web that referenced this pull request Jul 24, 2023
@guewen
Switch license in js file to be aligned with manifest
41e3698 
Ref: OCA#1462 (comment)

[UPD] Update web_ir_actions_act_view_reload.pot

[UPD] README.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments

@alexey-pelykh alexey-pelykh alexey-pelykh approved these changes

@simahawk simahawk simahawk approved these changes

@pnajman-modoolar pnajman-modoolar pnajman-modoolar approved these changes

@tarteo tarteo tarteo left review comments

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
8 participants
@guewen @alexey-pelykh @simahawk @OCA-git-bot @pedrobaeza @tarteo @pnajman-modoolar @oca-travis