[17.0][MIG] web_widget_open_tab: Migration to 17.0 #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inside other forms
Currently translated at 100.0% (6 of 6 strings) Translation: web-16.0/web-16.0-web_widget_open_tab Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_widget_open_tab/es/
|
/ocabot migration web_widget_open_tab |
|
I got an "Odoo Client Error" when testing on Runboat
|
|
@jcdrubay I think that 2 things were not in v16 either (or I couldn't make it work). I only was able to use that widget in an id field. I think it will be good improvements but maybe you should create an issue to ask for enhancement of this module. |
etobella
reviewed
Nov 26, 2023
| @@ -13,7 +13,7 @@ export class OpenTabWidget extends Component { | |||
| var url = window.location.href; | |||
| var searchParams = new URLSearchParams(url.split("#")[1]); | |||
| searchParams.set("view_type", "form"); | |||
| searchParams.set("id", this.props.value); | |||
| searchParams.set("id", this.props.record.data.id); | |||
There was a problem hiding this comment.
That might be the problem with the change suggested. By doing this, this will only work with id field
CRogos
reviewed
Mar 27, 2024
|
@moitabenfdz are you still working on this? |
moitabenfdz
force-pushed
the
17.0-mig-web_widget_open_tab
branch
from
b735f29
to
5ab1cf6
Compare
CRogos
approved these changes
May 14, 2024
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 9caf999. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.