Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][mig] web_widget_open_tab: Migration to 16.0 #2453

Merged
merged 29 commits into from
Jul 25, 2023
Merged

[16.0][mig] web_widget_open_tab: Migration to 16.0 #2453

merged 29 commits into from
Jul 25, 2023

Conversation

dsolanki-initos
Copy link
Contributor

No description provided.

etobella and others added 28 commits March 15, 2023 14:24
@etobella @dsolanki-initos
[11.0][ADD] web_widget_open_tab
684c78d
@AdriaGForgeFlow @dsolanki-initos
[IMP] web_widget_open_tab: keep breadcrumb
a72e44e
@etobella @dsolanki-initos
[11.0][FIX] open_tab: Open new tab with the wheel
cb98820
@etobella @dsolanki-initos
[MIG][12.0] web_widget_open_tab
9e44f5c
@oca-travis @dsolanki-initos
[UPD] Update web_widget_open_tab.pot
76de0fa
@OCA-git-bot @dsolanki-initos
[UPD] README.rst
44d8cf1
@OCA-git-bot @dsolanki-initos
[UPD] README.rst
99a262f
@OCA-git-bot @dsolanki-initos
[UPD] README.rst
5579b14
@etobella @dsolanki-initos
[12.0] web_widget_open_tab: Allow to open tab on dashboards or trees …
2495003 
…inside other forms
@oca-travis @dsolanki-initos
[UPD] Update web_widget_open_tab.pot
83f6826
@OCA-git-bot @dsolanki-initos
web_widget_open_tab 12.0.1.0.1
5cbbdd1
@claudiagn @dsolanki-initos
Added translation using Weblate (Spanish)
958724a
@claudiagn @dsolanki-initos
Translated using Weblate (Spanish)
53e440e 
Currently translated at 100.0% (2 of 2 strings)

Translation: web-12.0/web-12.0-web_widget_open_tab
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_widget_open_tab/es/
@claudiagn @dsolanki-initos
Added translation using Weblate (Catalan)
eeda701
@claudiagn @dsolanki-initos
Translated using Weblate (Catalan)
c44bc50 
Currently translated at 100.0% (2 of 2 strings)

Translation: web-12.0/web-12.0-web_widget_open_tab
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_widget_open_tab/ca/
@marcelsavegnago @dsolanki-initos
Added translation using Weblate (Portuguese (Brazil))
92f0af2
@rven @dsolanki-initos
[IMP] web_widget_open_tab: black, isort
95e946a
@rven @dsolanki-initos
[MIG] web_widget_open_tab: Migration to 13.0
fd65e00
@rven @dsolanki-initos
[IMP] web_widget_open_tab: black, isort
66798a5
@rven @dsolanki-initos
[MIG] web_widget_open_tab: Migration to 14.0
5b2478d
@oca-travis @dsolanki-initos
[UPD] Update web_widget_open_tab.pot
53f68b3
@OCA-git-bot @dsolanki-initos
[UPD] README.rst
fdb02d8
@Corneliuus @dsolanki-initos
Added translation using Weblate (German)
9df5198
@Corneliuus @dsolanki-initos
Translated using Weblate (German)
86bc5eb 
Currently translated at 100.0% (2 of 2 strings)

Translation: web-14.0/web-14.0-web_widget_open_tab
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_widget_open_tab/de/
@rven @dsolanki-initos
[MIG] web_widget_open_tab: Migration to 15.0
5f588f2
@dsolanki-initos
[UPD] Update web_widget_open_tab.pot
a9ba489
@OCA-git-bot @dsolanki-initos
[UPD] README.rst
90d830b
@dsolanki-initos
[IMP] web_widget_open_tab: pre-commit stuff
e4016f9
@dsolanki-initos dsolanki-initos mentioned this pull request Mar 15, 2023
Open
45 tasks
@tarteo
Copy link
Member

tarteo commented Mar 24, 2023

/ocabot migration web_widget_open_tab

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 24, 2023
AungKoKoLin1997
AungKoKoLin1997 approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review: LGTM

len-foss
len-foss approved these changes May 19, 2023
View reviewed changes
Copy link

@len-foss len-foss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. LGTM!

@minhthie
Copy link

On functional review, I think that it's good but should we consider using this widget for relation fields (m2o)?
For example, in Contract tree view, I add this widget=open_tab for field country_id. It should open a country form view in a new tab.
But for now, there is an error as shown below
image

@CRogos
Copy link
Contributor

CRogos commented Jul 7, 2023

On functional review, I think that it's good but should we consider using this widget for relation fields (m2o)? For example, in Contract tree view, I add this widget=open_tab for field country_id. It should open a country form view in a new tab. But for now, there is an error as shown below image

I've tested it with the helpdesk dashboard.
I get the same error message when setting the widget on a non-id field like these:


But in v15 these widget did not open the ticket_type_id form, but also the ticket form.

The widget is working fine when using the id field:

I agree that m2o would be a nice improvement but not necessary for the migration.

@pedrobaeza if you agree could you please merge the PR?

@pedrobaeza
Copy link
Member

Please add about m2o thing in the ROADMAP.

@CRogos
Copy link
Contributor

CRogos commented Jul 13, 2023

@dsolanki-initos could you add a ROADMAP.rst file in the readme folder with the note to add m2o support and add this to your last commit?

@CRogos
Copy link
Contributor

CRogos commented Jul 25, 2023

@pedrobaeza can we continue without the roadmap?

@pedrobaeza
Copy link
Member

OK, we'll add it later:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2453-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5b440d5 into OCA:16.0 Jul 25, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a6fcb67. Thanks a lot for contributing to OCA. ❤️

pedrobaeza added a commit that referenced this pull request Jul 25, 2023
@pedrobaeza
[IMP] web_widget_open_tab: Add ROADMAP
f1e9348 
According #2453 (comment)
@pedrobaeza
Copy link
Member

Roadmap added at f1e9348

moitabenfdz pushed a commit to DynAppsNV/web that referenced this pull request Nov 16, 2023
@pedrobaeza @moitabenfdz
[IMP] web_widget_open_tab: Add ROADMAP
d48de15 
According OCA#2453 (comment)
CRogos pushed a commit to c4a8-odoo/module-oca-web that referenced this pull request May 14, 2024
@pedrobaeza @CRogos
[IMP] web_widget_open_tab: Add ROADMAP
d37082a 
According OCA#2453 (comment)
CRogos pushed a commit to c4a8-odoo/module-oca-web that referenced this pull request May 14, 2024
@pedrobaeza @CRogos
[IMP] web_widget_open_tab: Add ROADMAP
6c4989f 
According OCA#2453 (comment)
CRogos pushed a commit to c4a8-odoo/module-oca-web that referenced this pull request May 14, 2024
@pedrobaeza @CRogos
[IMP] web_widget_open_tab: Add ROADMAP
c37e052 
According OCA#2453 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AungKoKoLin1997 AungKoKoLin1997 AungKoKoLin1997 approved these changes

@len-foss len-foss len-foss approved these changes

@CRogos CRogos CRogos approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.