Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][web_editor_background_color] Migrate to v10 #665

Merged
merged 3 commits into from
Jul 7, 2017

Conversation

yajo
Copy link
Member

@yajo yajo commented Jul 5, 2017

Now it fits into upstream's color picker, just adding a new tab at the end.

All known issues have been addressed.

@Tecnativa

yajo and others added 3 commits July 5, 2017 11:56
…A#582)

* [ADD][web_editor_background_color] Custom background color picker

This addon lets the user choose a preferred background color when editing some web content.

Works out of the box with `website` and `mass_mailing` addons, although requires none of those.

* [FIX] Avoid clicks removing dropdown menu

This happened specifically in Chrome as demonstrated in
OCA#582 (comment).

* [FIX] Use strict equality operator.
Now it fits into upstream's color picker, just adding a new tab at the end.

All known issues have been addressed.
@yajo yajo self-assigned this Jul 5, 2017
@yajo yajo added this to the 10.0 milestone Jul 5, 2017
@pedrobaeza pedrobaeza mentioned this pull request Jul 5, 2017
59 tasks
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried on runbot.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on rubot 👍

@moylop260 moylop260 merged commit 3635832 into OCA:10.0 Jul 7, 2017
@yajo yajo deleted the 10.0-web_editor_background_color branch July 7, 2017 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants