Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] website_form_recaptcha #693

Closed
wants to merge 42 commits into from

Conversation

bizzappdev
Copy link

No description provided.

lasley and others added 30 commits February 6, 2020 12:30
* Update website_form_recaptcha to v10
[FIX] remove en.po that was erroneously created by transbot
- Remove groups on ir_config_paramater records (gone in 11.0)
- Move error mapping to private function to allow translation
The test was passing a list while the method is expecting a string
Files don't need to have the execute flag on
flake8 was complaining about E501 line too long
Currently translated at 100,0% (12 of 12 strings)

Translation: website-11.0/website-11.0-website_form_recaptcha
Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_form_recaptcha/pt_BR/
Currently translated at 100,0% (12 of 12 strings)

Translation: website-11.0/website-11.0-website_form_recaptcha
Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_form_recaptcha/de/
Currently translated at 100.0% (12 of 12 strings)

Translation: website-11.0/website-11.0-website_form_recaptcha
Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_form_recaptcha/de/
Currently translated at 100,0% (12 of 12 strings)

Translation: website-11.0/website-11.0-website_form_recaptcha
Translate-URL: https://translation.odoo-community.org/projects/website-11-0/website-11-0-website_form_recaptcha/es/
- When website_crm_phone_validation is installed, the captcha validation
is called twice so the form allways fail as with a
'timeout-or-duplicate' error.
* API keys can now be configured via website settings
  which in turn allow to customize the values per website
  in a multi-website instance;

* move all internal APIs to the model `website.form.recaptcha`
  so that we do not depend anymore on the controller
  if we need to integrate it into other pieces of code.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
- Fix tests.
- Remove outdated tests.
- Remove unneeded data file.
- Add migration script.
@simahawk
Copy link

simahawk commented Feb 7, 2020

it's already done here #684

@simahawk simahawk closed this Feb 7, 2020
@bizzappdev
Copy link
Author

wow, I see now. #667 This was not up to date and that is why I migrated it again.

@simahawk
Copy link

simahawk commented Feb 7, 2020

wow, I see now. #667 This was not up to date and that is why I migrated it again.

yep, sorry for this. There's no automation there. In any case, before starting any new PR it's always a good thing to search by milestone and module name 😉

@pedrobaeza
Copy link
Member

The automation is in progress in OCA/oca-github-bot#97 😉

@simahawk
Copy link

simahawk commented Feb 7, 2020

The automation is in progress in OCA/oca-github-bot#97

I know! Thanks for it! I had a mental note somewhere to review it 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet