Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language and fontFamily in GT #32

Open
bertsky opened this issue May 23, 2019 · 3 comments
Open

language and fontFamily in GT #32

bertsky opened this issue May 23, 2019 · 3 comments
Assignees
@tboenig
Labels
groundtruth Groundtruth quality issues

Comments

@bertsky
Copy link
Contributor

bertsky commented May 23, 2019

Please correct me: I believe Word/@language and TextStyle/@fontFamily should be either used properly or not at all in the GT.

But I often see them wrong (with a tendency towards blackletter and German). E.g. in weigel_gnothi02_1618, word word_1479403541433_37 (which is clearly Greek) has language=German / fontFamily=antiqua, words w_w1aab1b1b2b3b1b1b7, w_w1aab1b1b2b3b1b1c23 and w_w1aab1b1b2b7b3ac21 (which are Latin) have language=German, and words w_w1aab1b1b2b7b9ac33 word_1488831895760_120 and word_1488831812931_118 (which are Latin antiqua) have language=German / fontFamily=blackletter.

Also, I believe that on the TextLine and TextRegion level, the TextStyle/@fontFamily should always be a (comma-separated) list of all the values on the lower levels.
@bertsky bertsky mentioned this issue May 29, 2019
Open
@kba kba assigned tboenig and unassigned tboenig Jul 9, 2019
@tboenig
Copy link
Contributor

tboenig commented Jul 11, 2019

We prepare a correction:

  • the @language will be fixed
  • the @fontFamily and @primaryLanguage will be deleted
  • the @custom will be deleted

@kba
Copy link
Member

kba commented Aug 21, 2019

@tboenig Has this been consistently fixed?

@cneud cneud added the groundtruth Groundtruth quality issues label Nov 5, 2019
@EEngl52
Copy link

EEngl52 commented Apr 6, 2020

@tboenig can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tboenig tboenig

Labels
groundtruth Groundtruth quality issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kba @cneud @tboenig @bertsky @EEngl52