Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix simplification of distincts #343

Merged
merged 1 commit into from Jul 22, 2020
Merged

fix simplification of distincts #343

merged 1 commit into from Jul 22, 2020

Conversation

iguerNL
Copy link
Contributor

@iguerNL iguerNL commented Jul 22, 2020 •
edited

bad simplification in eg distinct (a, a, b) should return false (true for n_ary_eq) instead of distinct(a,b)

@Gbury
Copy link
Collaborator

Gbury commented Jul 22, 2020

Shouldn't it return false instead in your example ? The PR code seems correct, but I think you more likely wanted to talk about the n-ary equality (which also affect n-ary pairwise disequality such as distinct).

@iguerNL
Copy link
Contributor Author

iguerNL commented Jul 22, 2020

Yes :-D

@iguerNL iguerNL merged commit 8f0b39c into OCamlPro:next Jul 22, 2020
@iguerNL iguerNL deleted the fix-distinct branch August 11, 2020 08:00
@ACoquereau ACoquereau mentioned this pull request Sep 8, 2020
Closed
ACoquereau pushed a commit to ACoquereau/alt-ergo that referenced this pull request Jan 25, 2021
@iguerNL
Merge pull request OCamlPro#343 from OriginLabs-Iguernlala/fix-distinct
5a0182e 
fix simplification of distincts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iguerNL @Gbury