Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a ocp-search that looks for values by their (fuzzy) name #99

Closed
wants to merge 1 commit into from
Closed

Conversation

c-cube
Copy link

@c-cube c-cube commented Oct 8, 2016

This is not ready yet (it's a bit too slow to load all the libraries because it cannot benefit from the same load-on-demand behavior that completion uses). I suspect it might be better used in ocp-browser (which is long-lived, so taking a few seconds to load in the background at the beginning would not hurt).

@CLAassistant
Copy link

CLAassistant commented Oct 8, 2016

CLA assistant check
All committers have signed the CLA.

@AltGr
Copy link
Member

AltGr commented Feb 13, 2017

Thanks! This seems nice though. This may get quicker after the first run due to file caching, and if you just have to search for one or two terms, that might be acceptable, but indeed, making it persistent would avoid most of the problem, either through an interactive prompt or ocp-browser.

@Drup
Copy link
Collaborator

Drup commented Apr 13, 2018

I think having an explicit switch to use the fuzzy search in ocp-browser could be useful. If we limit it to the current module, then the perf penalty is non-existant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants