Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many asserts are discharged to the SMT solver #122

Closed
krtab opened this issue Jan 23, 2024 · 1 comment
Closed

Too many asserts are discharged to the SMT solver #122

krtab opened this issue Jan 23, 2024 · 1 comment

Comments

@krtab
Copy link
Collaborator

krtab commented Jan 23, 2024

There's a bug regarding the Ptr type returned by owi_alloc. I just ran this locally, and with -w 8 owi is making 8200 calls to the solver, totaling 34s in the solver. This means that the expressions in owi_assert, i.e., stuff like this:

calling func : func owi_assert
stack        : [  ]
running instr: local.get 0
stack        : [ (i32.of_bool (i32.eq (i32.rem (Ptr (i32 8390672) (i32 0)) (i32 1)) (i32 0))) ]

Is being discharged to the solver instead of being solved concretely

Originally posted by @filipeom in #118 (comment)

@krtab
Copy link
Collaborator Author

krtab commented Jan 26, 2024

Constant booleans are not passed to the solver currently

let check sym_bool thread =
let (S (solver_module, solver)) = Thread.solver thread in
let pc = Thread.pc thread in
let no = S.Bool.not sym_bool in
let no = Expr.simplify no in
match no.e with
| Val True -> false
| Val False -> true

So I think this boils down to having enough reductions implemented in encoding

@krtab krtab closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant