Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize cookieBanner component #11

Closed
2 tasks done
tobias-kuendig opened this issue Jun 19, 2018 · 6 comments
Closed
2 tasks done

Optimize cookieBanner component #11

tobias-kuendig opened this issue Jun 19, 2018 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tobias-kuendig
Copy link
Member

tobias-kuendig commented Jun 19, 2018

  • Add an option to hide cookie group checkboxes (c519c8d)
  • Add example banner messages for different EU countries

via via #8

@tobias-kuendig tobias-kuendig added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 19, 2018
@ghost
Copy link

ghost commented Jun 19, 2018

Add example banner messages for different EU countries

~Have read up and it seems the message doesn't matter, depending on each country although there are different laws within each country with regards to the Banner and I will add the list below. Maybe this can be added to the notes section to help users.

@damsfx
Copy link
Contributor

damsfx commented Jun 20, 2018

@ayumihamsaki ... awesome work !

@ghost
Copy link

ghost commented Jun 21, 2018

Also could create a list for the "Contact Links of Data Controller" and place the list of links in the Info and Help Section.

For example GA has a special Opt-Out webpage that should be linked and most people would not know about it. So making a list of the most common ones and placing it in the new Info and Help Section should also make things easier to fill out the form.

e.g.

aaa

@damsfx
Copy link
Contributor

damsfx commented Mar 18, 2024

  • Add an option to hide cookie group checkboxes (c519c8d)

This commit don't add an option to show/hide cookie group checkboxes, but removed them completely.

@tobias-kuendig Are you open to a PR that re-introduced then in a dedicated component (maybe banner plus) ?

@tobias-kuendig
Copy link
Member Author

@damsfx that was a long time ago, so I have no idea what the reasoning was.

What would you think about a PR that adds the properties back on the component so you can utilize them in your partials? I'd rather not have an additional component to maintain.

@damsfx
Copy link
Contributor

damsfx commented Apr 2, 2024

@damsfx that was a long time ago, so I have no idea what the reasoning was.

🤣

What would you think about a PR that adds the properties back on the component so you can utilize them in your partials? I'd rather not have an additional component to maintain.

As I didn't get an answer from you and needed one quickly, I created my own plugin to add this new component:
https://github.com/Hounddd/wn-gdprplus-plugin

I really needed a component that would simplify my work with Google Consent Mode v2.
By the way, I used CSS variables to quickly "theme" the component.

Of course, I prefer the idea of a more universal component that would allow the display of a simple or more complex banner.
On the other hand, I think that the way the user's response is handled differs completely from one display to another.
That's why I opted for a component that extends the basic component, thus avoiding too much maintenance.

It's up to us to find the best options to offer the best of both worlds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants