Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badly Formed IRIs #116

Closed
mark-jensen opened this issue Nov 10, 2017 · 1 comment
Closed

Badly Formed IRIs #116

mark-jensen opened this issue Nov 10, 2017 · 1 comment

Comments

@mark-jensen
Copy link
Contributor

The following classes do not have numeric IDs and their IRIs are badly formed:
http://purl.obolibrary.org/obo/ogms.owl#ancillary_health_care_process
http://purl.obolibrary.org/obo/ogms.owl#disease_stage
http://purl.obolibrary.org/obo/ogms.owl#health_care_process-_assay
http://purl.obolibrary.org/obo/ogms.owl#health_care_process-_biomaterial_transformation
http://purl.obolibrary.org/obo/ogms.owl#health_care_process-_data_transformation

Although I question if these belong in OGMS as-defined, in the short term they at least should be given OBO-Foundry-compliant identifiers.

I made the fixes in a branch and did a PR. I will go ahead and merge providing no one disagrees.

http://purl.obolibrary.org/obo/OGMS_0000107 (ancillary health care process)
http://purl.obolibrary.org/obo/OGMS_0000108 (health care process assay)
http://purl.obolibrary.org/obo/OGMS_0000109 (health care process biomaterial transformation)
http://purl.obolibrary.org/obo/OGMS_0000110 (health care process data transformation)

No fix was made to disease stage. See #105 for discussion.

mark-jensen added a commit that referenced this issue Nov 10, 2017
Fixed badly formed IRIs and added comment to `disease stage`. #116
@mark-jensen mark-jensen mentioned this issue Nov 10, 2017
@mark-jensen
Copy link
Contributor Author

closed with #117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant