-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring to range loop #2583
Conversation
OgreMain/src/OgreCamera.cpp
Outdated
@@ -174,7 +171,7 @@ namespace Ogre { | |||
|
|||
Quaternion targetWorldOrientation; | |||
|
|||
if( mYawFixed ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer not to do these whitespace changes manually. They are trivial to do with clang-format. I just refrained to apply them as such commit introduces lots of noise in the code (think of open pull requests) without adding much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a .clang-format ready to use somewhere or we can use llvm with 4 space of indentation ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the clang-format I use to #2584. But still, I do not think we should apply it to existing code just like that..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied a quite similar format than your, I think it looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like I said initially, i dont think it make sense to format existing code just for the sake of it..
Ok I got if that keeps similar the actual style would be worth to make it, anyway I am reverting or creating a new commit. |
No description provided.