Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring to range loop #2583

Merged
merged 4 commits into from
Sep 11, 2022
Merged

refactoring to range loop #2583

merged 4 commits into from
Sep 11, 2022

Conversation

Joilnen
Copy link
Contributor

@Joilnen Joilnen commented Sep 9, 2022

No description provided.

@@ -174,7 +171,7 @@ namespace Ogre {

Quaternion targetWorldOrientation;

if( mYawFixed )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer not to do these whitespace changes manually. They are trivial to do with clang-format. I just refrained to apply them as such commit introduces lots of noise in the code (think of open pull requests) without adding much.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a .clang-format ready to use somewhere or we can use llvm with 4 space of indentation ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the clang-format I use to #2584. But still, I do not think we should apply it to existing code just like that..

Copy link
Contributor Author

@Joilnen Joilnen Sep 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applied a quite similar format than your, I think it looks good

Copy link
Member

@paroj paroj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like I said initially, i dont think it make sense to format existing code just for the sake of it..

@Joilnen
Copy link
Contributor Author

Joilnen commented Sep 11, 2022

Ok I got if that keeps similar the actual style would be worth to make it, anyway I am reverting or creating a new commit.

@Joilnen Joilnen requested a review from paroj September 11, 2022 13:14
@Joilnen Joilnen changed the title refactoring and fixing the style refactoring to range loop Sep 11, 2022
@paroj paroj merged commit 34a6bd8 into OGRECave:master Sep 11, 2022
@Joilnen Joilnen deleted the fix_07 branch June 12, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants