Correct vocabulary for person counts is used (#2860)

Fixes #2859.

(cherry picked from commit 1fa691d)

js/pages/vocabulary/components/search.html

@@ -79,7 +79,7 @@
           options: resultSources,
           optionsText: 'sourceName',
           optionsValue: 'sourceKey',
-          value: currentResultSource,
+          value: currentResultSourceKey,
           event: { change: refreshRecordCounts }
         "></select>
 		</div>

js/pages/vocabulary/components/search.js

@@ -263,14 +263,14 @@ define([
 					});
 			}
 
-			this.currentResultSource = ko.observable();
+			this.currentResultSourceKey = ko.observable();
 			this.resultSources = ko.computed(() => {
 					const resultSources = [];
 					sharedState.sources().forEach((source) => {
 							if (source.hasResults && authApi.isPermittedAccessSource(source.sourceKey)) {
 									resultSources.push(source);
 									if (source.resultsUrl === sharedState.resultsUrl()) {
-											this.currentResultSource(source);
+											this.currentResultSourceKey(source.sourceKey);
 									}
 							}
 					})
@@ -432,7 +432,7 @@ define([
 					this.searchExecuted(true); // signals 'no results found' message
 					return;
 				}
-				await vocabularyProvider.loadDensity(recommendedConcepts, this.currentResultSource().sourceKey,(v)=>parseInt(v,10)); // formatting values as ints
+				await vocabularyProvider.loadDensity(recommendedConcepts, this.currentResultSourceKey(),(v)=>parseInt(v,10)); // formatting values as ints
 				recommendedConcepts.sort((a,b) => b.DESCENDANT_RECORD_COUNT - a.DESCENDANT_RECORD_COUNT); // sort descending order by DRC
 				const conceptSetStore = ConceptSetStore.repository();
 				const items = commonUtils.buildConceptSetItems([recommendedConcepts[0]], {includeDescendants: true});
@@ -468,7 +468,7 @@ define([
 				throw { message: 'No results found', results };
 			}
 
-			const promise = vocabularyProvider.loadDensity(results, this.currentResultSource().sourceKey);
+			const promise = vocabularyProvider.loadDensity(results, this.currentResultSourceKey());
 			promise.then(() => {
 				this.data(this.normalizeSearchResults(results));
 			});
@@ -514,12 +514,12 @@ define([
 				return;
 			}
 
-			this.currentResultSource(this.resultSources().find(source => source.sourceKey == event.target.value));
+			this.currentResultSourceKey(event.target.value);
 
 			this.recordCountsRefreshing(true);
 			this.columnHeadersWithIcons.forEach(c => this.toggleCountColumnHeaderSpin(c, true));
 			const results = this.data();
-			await vocabularyProvider.loadDensity(results, this.currentResultSource().sourceKey);
+			await vocabularyProvider.loadDensity(results, this.currentResultSourceKey());
 			this.data(results);
 			this.columnHeadersWithIcons.forEach(c => this.toggleCountColumnHeaderSpin(c, false));
 			this.recordCountsRefreshing(false);