Correct vocabulary for person counts is used #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisknoll
requested changes
May 23, 2023
| @@ -79,7 +79,7 @@ | |||
| options: resultSources, | |||
| optionsText: 'sourceName', | |||
| optionsValue: 'sourceKey', | |||
| value: currentResultSource, | |||
| value: currentResultSource().sourceKey, | |||
There was a problem hiding this comment.
This looks like 1currentResultSource()1 is an observable to a Source object, but should we be binding the dropdown to a full-source object instead of just a observable that stores what the current source selection? I can't tell from this review, but what is in currentResultSource() and should we be updating the 1 field in it (sourceKey) when instead it would make more sense to just store the currentResultSource's key? Maybe this var should be called currentResultSourceKey?
There was a problem hiding this comment.
I removed currentResultSource, now only currentResultSourceKey is used for search
chrisknoll
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2859