-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address style concerns and config option to hide permission manager button #2873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gside of write permissions
… a concept set -- further work needed to ensure concept sets are listed and that the permissions can be revoked by the user.
… to concept sets. Removing write access triggers an error that needs investigation but read access can be both added and revoked
merge from remote repository
…on the new configLocal.enablePermissionManagement variable to the other applications in Atlas
@rkboyce from our discussion on the Atlas WG call, these changes are looking good from my review. Per our discussion, you'll be working out the corresponding WebAPI changes for this work after the 7/4 break. |
Sorry - closing this pull request since the update should have happened on draft pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The style concerns focused the proper use of variable types in Permisssion.js and the use of 'perm_type' instead 'role' in parameter names where the former was the correct choice.
There is now a new configuration option for configLocal :
I added code throughout the pages to hide the button when the enablePermissionManagement = false;
I did not address using tabs or pills for the configure access modal now that read permissions are a part of that. Neither the ability to assert that an artifact is globally readable. I would like to punt these changes to 2.15 because of limited time on my part.