Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address style concerns and config option to hide permission manager button #2873

Closed
wants to merge 12 commits into from

Conversation

rkboyce
Copy link
Contributor

@rkboyce rkboyce commented Jun 25, 2023

The style concerns focused the proper use of variable types in Permisssion.js and the use of 'perm_type' instead 'role' in parameter names where the former was the correct choice.

There is now a new configuration option for configLocal :

        // This tells Atlas to show the 'lock' icon to the user when
        // viewing concept sets, cohort definitions, and other
        // artificats so that the can edit READ and WRITE
        // permissions. By default, this is set to true
        configLocal.enablePermissionManagement = true;

I added code throughout the pages to hide the button when the enablePermissionManagement = false;

I did not address using tabs or pills for the configure access modal now that read permissions are a part of that. Neither the ability to assert that an artifact is globally readable. I would like to punt these changes to 2.15 because of limited time on my part.

@anthonysena
Copy link
Collaborator

@rkboyce from our discussion on the Atlas WG call, these changes are looking good from my review. Per our discussion, you'll be working out the corresponding WebAPI changes for this work after the 7/4 break.

@chrisknoll
Copy link
Collaborator

I'm confused by these 2 PRS:
#2873
#2849

Are these the same things? If so, should these be put into a single PR so we don't have confusion between them?

@rkboyce
Copy link
Contributor Author

rkboyce commented Jul 19, 2023

Sorry - closing this pull request since the update should have happened on draft pull request

@rkboyce rkboyce closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants