Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read permissions #2849

Merged
merged 12 commits into from Jul 31, 2023

Conversation

rkboyce
Copy link
Contributor

@rkboyce rkboyce commented Apr 4, 2023

No description provided.

rkboyce and others added 7 commits March 21, 2023 15:02
… a concept set -- further work needed to ensure concept sets are listed and that the permissions can be revoked by the user.
… to concept sets. Removing write access triggers an error that needs investigation but read access can be both added and revoked
merge from remote repo into fork
@rkboyce
Copy link
Contributor Author

rkboyce commented Jul 19, 2023

The style concerns focused the proper use of variable types in Permisssion.js and the use of 'perm_type' instead 'role' in parameter names where the former was the correct choice.

There is now a new configuration option for configLocal :

        // This tells Atlas to show the 'lock' icon to the user when
        // viewing concept sets, cohort definitions, and other
        // artificats so that the can edit READ and WRITE
        // permissions. By default, this is set to true
        configLocal.enablePermissionManagement = true;

I added code throughout the pages to hide the button when the enablePermissionManagement = false;

I did not address using tabs or pills for the configure access modal now that read permissions are a part of that. Neither the ability to assert that an artifact is globally readable. I would like to punt these changes to 2.15 because of limited time on my part.

@rkboyce rkboyce marked this pull request as ready for review July 23, 2023 03:36
@chrisknoll chrisknoll changed the base branch from master to webapi/issue-2300 July 31, 2023 20:38
@chrisknoll chrisknoll merged commit b592e21 into OHDSI:webapi/issue-2300 Jul 31, 2023
2 checks passed
chrisknoll added a commit that referenced this pull request Aug 14, 2023
Adding the ability to see read permissions alongside of write permissions
Added flag enablePermissionManagement to control UI element to assign permissions.
Removed pureComputed from non-observable values.

Co-authored-by: Richard D Boyce, PhD <boycer@u.washington.edu>
@rkboyce rkboyce deleted the add_read_permissions branch February 12, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants