Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[measurement table] missing unit_source_concept_id #259

Closed
parisni opened this issue Apr 27, 2019 · 14 comments
Closed

[measurement table] missing unit_source_concept_id #259

parisni opened this issue Apr 27, 2019 · 14 comments

Comments

@parisni
Copy link

parisni commented Apr 27, 2019

Hi

according to this http://forums.ohdsi.org/t/store-original-and-transformed-unit-in-measurement/4348/3
it is necessary to add the unit_source_concept_id

@clairblacketer
Copy link
Contributor

Thanks @parisni. I will need a proposal drawn up so we can discuss at a CDM workgroup meeting. This template helps organize the request, use cases, etc.

@vojtechhuser
Copy link
Collaborator

There is a larger consideration. If we store super nicely the original units (and we converted the value), we may think about storing the original value
(if I converted pounds to kg - there is source value as number as well). Where do we stop?

@parisni
Copy link
Author

parisni commented May 7, 2019

hi @vojtechhuser

Where do we stop?

From a implementer perspective, I am not very comfortable to lose local informations (such original value).
For a standard analyst perspective, I agree it does not matter whether such local code exist or not.

Please keep in mind that OMOP is also a model for internal use and also local codes are used a lot. If this aspect is lost, the model would lose interest in my opinion.

This is why I am asking for extending consistency and keep the local code in the model.

@cgreich
Copy link
Contributor

cgreich commented May 7, 2019

@parisni:

No stress. We are not going to drop the source values and source concepts. What Vojtech is looking at is to standardize the measurements, so they are all in the same standard units. That will require conversion. From a analytic perspective, even local, this would be a very nice achievement. Actually, particularly locally, because most institutions use more than one clinical lab, and they all spit out whatever jibberish they want. To get that under control would be a true strong suite of the CDM.

@vojtechhuser
Copy link
Collaborator

I will reply on forum

@vojtechhuser
Copy link
Collaborator

hmmm. what about 5 ft 1 inch..... (OMG) I doubt there is CID for that and not sure I would love to create it. (but we may have to).

@clairblacketer
Copy link
Contributor

Hi @parisni this issue has been added to the June 4th CDM workgroup meeting

@parisni
Copy link
Author

parisni commented May 17, 2019

hi @clairblacketer thanks. I will add several related issues soon and hope all the stuff will be discussed

@clairblacketer
Copy link
Contributor

clairblacketer commented Jun 3, 2019

Hi @parisni and @vojtechhuser June 4th meeting of the CDM workgroup has moved to June 11 because of the Cleveland F2F. Agenda can be found here.

@parisni
Copy link
Author

parisni commented Jun 3, 2019

hi @clairblacketer thanks a lot !

@vojtechhuser
Copy link
Collaborator

Here is the conclusion. We hope to add a column. Moving this Themis issue back to here since Themis is now terminated.

PROBLEM: original data can not be stored fully

FORUM: see forum link here #259

SOLUTION:
add new column to CDM unit_source_concept_id (optional) this is representation of unit_source_value as concept_id
(data type as all other CIDs, optional)

@vojtechhuser
Copy link
Collaborator

Why is this urgent: We want to convert weight in lb into kg. In order to document that the original data was in lb, we need this field. This will allow much greater standardization of measurement data.

@clairblacketer
Copy link
Contributor

Labelled as documentation for the 2021 CDM Hackathon

Final Decision

The field UNIT_SOURCE_CONCEPT_ID needs to be added to the MEASUREMENT table.

@NACHC-CAD
Copy link
Contributor

@aandryc: @NACHC-CAD (John Gresh) will take this one at the hackathon.

clairblacketer added a commit that referenced this issue Aug 18, 2021
Issue #259 [measurement table] added unit_source_concept_id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants