Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup warnings #34

Merged
merged 1 commit into from
Oct 21, 2016
Merged

Cleanup warnings #34

merged 1 commit into from
Oct 21, 2016

Conversation

chrisknoll
Copy link
Contributor

Declare variables as size_t to fix warnings comparing unsigned and signed ints.

Fixes #33.

@codecov-io
Copy link

Current coverage is 59.71% (diff: 100%)

Merging #34 into master will not change coverage

@@             master        #34   diff @@
==========================================
  Files            71         71          
  Lines          6848       6848          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           4089       4089          
  Misses         2759       2759          
  Partials          0          0          

Powered by Codecov. Last update dab11f3...9a104ab

@msuchard
Copy link
Member

Thanks!

@msuchard msuchard closed this Oct 21, 2016
@chrisknoll
Copy link
Contributor Author

Was there something wrong with this PR that you didn't want to merge into master?

@msuchard msuchard reopened this Oct 21, 2016
@msuchard msuchard merged commit b6959f7 into OHDSI:master Oct 21, 2016
@msuchard
Copy link
Member

Ooops ... sorry @chrisknoll - I hit the wrong button. I am a bad collaborator.

@chrisknoll
Copy link
Contributor Author

Nah, it's just all this GUI stuff is complicated. Give me a github CLI any day! haha

@chrisknoll chrisknoll deleted the issue_33 branch October 21, 2016 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receiving warnings when building from source in R 3.3.1
3 participants