Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added MINs from rxnconso (https://github.com/OHDSI/Vocabulary-v5.0/is… #640

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

hardhouse
Copy link
Contributor

…sues/632)

Copy link
Contributor

@mik-ohdsi mik-ohdsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Results seem to be as expected.
select * from dev_rxnorm.concept c
left join dev_rxnorm.concept_relationship cr
ON cr.concept_id_1 = c.concept_id OR cr.concept_id_2 = c.concept_id
where c.concept_class_id='Multiple Ingredients' and c.vocabulary_id='RxNorm' and c.valid_start_date > '2022-06-01';

@mik-ohdsi
Copy link
Contributor

I have asked @Alexdavv to review one more thing I am not sure is okay: if there would be new RxE entries that are duplicates to existing ones...

@hardhouse
Copy link
Contributor Author

so what do we do then?

@cgreich
Copy link
Contributor

cgreich commented Jun 15, 2022

Don't forget the links to ingredients and drug forms. What do you do with the drug components? They are always single.

@mik-ohdsi
Copy link
Contributor

mik-ohdsi commented Jun 16, 2022

I have asked @Alexdavv to review one more thing I am not sure is okay: if there would be new RxE entries that are duplicates to existing ones...

the above comment was not meant to go here but into the Investigational Drugs... but @cgreich is right about the links. The ones to the ingredients are looking good. Drug forms / components I haven't checked. I thought MINs lead a somewhat solitary life for now and have been added, but are not completely integrated into the full hierarchy (kind of work in progress but wasn't tackled as it seemed to be too difficult?)

@cgreich
Copy link
Contributor

cgreich commented Jun 21, 2022

Where can we check it?

@mik-ohdsi
Copy link
Contributor

Where can we check it?
@cgreich
see that little awkward query above, it should provide you with some insight.

@cgreich
Copy link
Contributor

cgreich commented Jun 21, 2022

But where is that? DevV5?

Copy link
Member

@Alexdavv Alexdavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only erroneous diff is the following concept. Added to the booboo list

19051528 219329 Potassium Chloride-Potassium Gluconate Ingredient Non-standard Invalid Drug RxNorm

Wrong concept_class. Has to be a MIN

@Alexdavv Alexdavv merged commit a5ae9cf into master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants