Venn diagram #2179
Merged
Venn diagram #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-abushkevich
suggested changes
Dec 16, 2022
| @@ -1704,7 +1704,9 @@ | |||
| "saveFromComparisonNameTail": " - From Comparison", | |||
| "saveMessage": "Save New Concept Set From Selection Below", | |||
| "saveWarning": "You must save the current concept set before you can perform this comparison.", | |||
| "viewCountMessage": "View database record counts (RC) and descendant record counts (DRC) for:" | |||
| "vennDiagram": "Venn Diagram", | |||
| "viewCountMessage": "View database record counts (RC) and descendant record counts (DRC) for:", | |||
There was a problem hiding this comment.
Comma at the end makes the JSON invalid. Remove it.
anton-abushkevich
suggested changes
Dec 16, 2022
| "viewCountMessage": "View database record counts (RC) and descendant record counts (DRC) for:" | ||
|
|
There was a problem hiding this comment.
Delete empty line. Line count in all localization files should be equal.
There was a problem hiding this comment.
Btw: while it's a good check to ensure localization lines should be equal across files, I noticed that the order of keys is out of order across files. This makes it difficult to use something like WinMerge to find differences in files, where we could find out that a key exists in one file and is missing in another (but this would only work if the keys were in the same order).
Just something to think about for a future update.
anton-abushkevich
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added locales to venn diagram