Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement header data callbacks #28

Closed
ivanr opened this issue Sep 18, 2012 · 1 comment
Closed

Implement header data callbacks #28

ivanr opened this issue Sep 18, 2012 · 1 comment

Comments

@ivanr
Copy link
Contributor

ivanr commented Sep 18, 2012

We need new header data callbacks to use when library users are interested in seeing raw header data. There are 2 use cases that we need to handle.

In the first use case, the user cares only about complete (potentially buffered) chunks of data. Normally, all request headers arrive at once in a single buffer, and we can pass the buffer directly to the user. When fragmentation occurs, we will be forced to buffer. But, even in this use case, the callback can potentially be invoked twice. Once for the first header batch, and then the second time if trailing headers are included.

A further complication is if the user is expecting LibHTP to pre-process headers, reassembling the folded ones, and combining headers with the same names. We have a similar feature today.

In the second use case, we send raw header data to the user as we get it ourselves. This is easy to implement, and allows for fully streaming inspection. See #27 for a further discussion.

@ivanr
Copy link
Contributor Author

ivanr commented Feb 21, 2013

Removing enhancements from the issue tracker.

@ivanr ivanr closed this as completed Feb 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant