Backport/bug/5934 determining engine mode v6 #8655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 30, 2023 16:50
Configuration and behavior of HTP app layer depends on the copy mode of Suricata engine. Copy mode was set after the app layer setup. Decision of engine's copy mode operation is now made earlier. Initializing engine mode with a value of unknown signals a bug when the engine mode has not been determined but is already queried by other functions. Ticket: OISF#5934
| @@ -246,13 +246,24 @@ int SuriHasSigFile(void) | |||
| return (suricata.sig_file != NULL); | |||
| } | |||
|
|
|||
| int EngineModeIsUnknown(void) | |||
There was a problem hiding this comment.
I would like to see this appear first in a PR to master, only to be backported if needed.
|
Information: ERROR: QA failed on SURI_TLPW1_files_sha256.
Pipeline 12930 |
|
Continues in #8801 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #8649
https://redmine.openinfosecfoundation.org/issues/5934
https://redmine.openinfosecfoundation.org/issues/5958
Describe changes: