backport: Engine mode fixes v7 #8801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 3, 2023 11:47
BPF codebase queried engine mode earlier than it was determined from the configuration file/command line. As a result it used the default (IDS) mode where it could've been configured later on to the IPS mode. This could lead into an undefined behavior as some Suricata modules behave according to the engine mode. PF-Ring, Netmap and AF-Packet all shared almost identical code for determining the engine mode. It was put into one common function. Omitted the usage of SCStrdup function in PF-Ring module as it is uppercased during thread initialization phase. Ticket: OISF#5958
Move evaluation of engine runmode to an earlier phase so that dependend modules rely on properly configured engine runmode. Ticket: OISF#5958
To prevent unset values of engine runmode, this commit introduces unknown runmode which can detect when engine runmode is being used uninitialized. Ticket: OISF#6033
|
Information: QA ran without warnings. Pipeline 13540 |
Merged
|
Merged in #8810, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #8655
https://redmine.openinfosecfoundation.org/issues/5934
https://redmine.openinfosecfoundation.org/issues/5958
https://redmine.openinfosecfoundation.org/issues/6033
Describe changes: