Eq 1184 cannot launch eq in welsh #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've finished manually fixing up the guidance notes that didn't make it through the schema/script changes. There are still missing translations in household, pretty sure they're all interstitial blocks. Best to get a Welsh linguist to do a pass through? |
jonnyshaw89
approved these changes
Jun 22, 2017
|
Occured to me that most/all of the missing translations are probably from interstitial sections that are now blocks. I've gone through and hand ported them (there wern't many). Just a couple of missing translations now. |
ajmaddaford
approved these changes
Jun 22, 2017
It is possible to extract and generate new translations based on the latest schema structure
adoublebarrel
force-pushed
the
eq-1184-cannot-launch-eq-in-welsh
branch
from
4d61734
to
c076228
Compare
iwootten
pushed a commit
that referenced
this pull request
Feb 21, 2019
# This is the 1st commit message: Add support for translation of schemas using Pot Files # This is the commit message #2: Fix broken tests # This is the commit message #3: Correct spacing # This is the commit message #4: Remove test output from repo # This is the commit message #5: Label schema appropriately # This is the commit message #6: Tidy up naming # This is the commit message #7: Move main method into extractor class # This is the commit message #8: Use static methods where appropriate # This is the commit message #9: Add csv tranform test # This is the commit message #10: Use argparse throughout # This is the commit message #11: Correct spacing # This is the commit message #12: Remove common methods and put them in one place # This is the commit message #13: Remove common methods and put them in one place # This is the commit message #14: Correct output path # This is the commit message #15: Remove output from test # This is the commit message #16: Create paths when they don't exist # This is the commit message #17: Move translator class into separate file # This is the commit message #18: Correct Spacing # This is the commit message #19: Remove ability to transform to xls # This is the commit message #20: Remove unused import # This is the commit message #21: Remove unneccessary translation object call # This is the commit message #22: Add missing method # This is the commit message #23: Correct spacing # This is the commit message #24: Remove all xls transforms from repo # This is the commit message #25: Add newline to header to be importable # This is the commit message #26: Remove all shell scripts and replace with python # This is the commit message #27: Workaround for travis numpy weirdness # This is the commit message #28: Block empty legal_basis # This is the commit message #29: Block empty legal_basis # This is the commit message #30: Block missin legal basis # This is the commit message #31: Remove csv conversion from extractor # This is the commit message #32: Update readme # This is the commit message #33: Remove TODO's # This is the commit message #34: Only allow po files # This is the commit message #35: Remove condition # This is the commit message #36: Only ask for output path on save # This is the commit message #37: Remove context to meet Adam's original method calls # This is the commit message #38: Correct argument description: # This is the commit message #39: Use cwd for source of parent # This is the commit message #40: Remove '_translate_' from naming # This is the commit message #41: Remove duplicate file # This is the commit message #42: Don't attempt to translate if template but no schema # This is the commit message #43: Add better description # This is the commit message #44: Address comment # This is the commit message #45: Remove context from everything in extract template except answer options. Only print answer id's as template comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Trello Card
This is a fix for the broken translations system as a knock on effect of changes to survey runners survey json schema.
How To Review
You can run this in eq-survey-runner if you update scripts/translate_schemas.sh to checkout this branch.
I've left the previous spreadsheets generated by the translation extract script alongside the newly generated ones for comparison.
You should be able to run the pre-existing scripts as before.
There's a new script which merges two translation scripts together, it's command line executable and it should be self descriptive when fed a -h.
Fixed Issues
Guidance notes have been completed by hand but a second pair of eyes cast over the translations would be appreciated.
Known issues
The interstitial blocks don't have any translations. This seems to only affect census househould? The required translations are just one or two words but my Welsh is non-existent.