Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting of UUIDs is incorrect #857

Closed
d3zd3z opened this issue Jun 15, 2016 · 2 comments · Fixed by OP-TEE/optee_test#150
Closed

Formatting of UUIDs is incorrect #857

d3zd3z opened this issue Jun 15, 2016 · 2 comments · Fixed by OP-TEE/optee_test#150
Labels
bug

Comments

@d3zd3z
Copy link
Contributor

d3zd3z commented Jun 15, 2016

Although GlobalPlatform specifies that TAs and such are identified with UUIDs, we don't format them quite right when turning them into strings. Per https://www.ietf.org/rfc/rfc4122.txt, there should be another hyphen after the first two bytes of clockSeqAndNode.

Unfortunately, fixing this would break compatibility between how TAs are built, and when the OS loads them. Perhaps we should fix it at a significant release.
@jforissier
Copy link
Contributor

Very true... +1 for fixing this when convenient.

@d3zd3z
Copy link
Contributor Author

d3zd3z commented Aug 2, 2016

This is also related to the endianness issue in #858.

@ghost ghost added the bug label Nov 3, 2016
jenswi-linaro added a commit to jenswi-linaro/optee_os that referenced this issue Dec 8, 2016
@jenswi-linaro
Format UUID strings correctly
177602e 
Prior to this patch although GlobalPlatform specifies that TAs and such
are identified with UUIDs, we don't format them quite right when turning
them into strings. Per https://www.ietf.org/rfc/rfc4122.txt, there
should be another hyphen after the first two bytes of clockSeqAndNode.

Unfortunately, fixing this breaks compatibility between how TAs are
built, and when the OS loads them.

With this patch UUID string are formated with the additional hyphen as
for instance: f81d4fae-7dec-11d0-a765-00a0c91e6bf6

Fixes: OP-TEE#857
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
jenswi-linaro added a commit to jenswi-linaro/optee_test that referenced this issue Dec 8, 2016
@jenswi-linaro
Format UUID strings correctly
b9baa5b 
Prior to this patch although GlobalPlatform specifies that TAs and such
are identified with UUIDs, we don't format them quite right when turning
them into strings. Per https://www.ietf.org/rfc/rfc4122.txt, there
should be another hyphen after the first two bytes of clockSeqAndNode.

Unfortunately, fixing this breaks compatibility between how TAs are
built, and when the OS loads them.

With this patch UUID string are formated with the additional hyphen as
for instance: f81d4fae-7dec-11d0-a765-00a0c91e6bf6

Fixes: OP-TEE/optee_os#857
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
jenswi-linaro added a commit to jenswi-linaro/optee_client that referenced this issue Dec 8, 2016
@jenswi-linaro
Format UUID strings correctly
1a519ea 
Prior to this patch although GlobalPlatform specifies that TAs and such
are identified with UUIDs, we don't format them quite right when turning
them into strings. Per https://www.ietf.org/rfc/rfc4122.txt, there
should be another hyphen after the first two bytes of clockSeqAndNode.

Unfortunately, fixing this breaks compatibility between how TAs are
built, and when the OS loads them.

With this patch UUID string are formated with the additional hyphen as
for instance: f81d4fae-7dec-11d0-a765-00a0c91e6bf6

Fixes: OP-TEE/optee_os#857
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
This was referenced Dec 8, 2016
Merged
Merged
Merged
jenswi-linaro added a commit to jenswi-linaro/optee_test that referenced this issue Dec 9, 2016
@jenswi-linaro
Format UUID strings correctly
6203b87 
Prior to this patch although GlobalPlatform specifies that TAs and such
are identified with UUIDs, we don't format them quite right when turning
them into strings. Per https://www.ietf.org/rfc/rfc4122.txt, there
should be another hyphen after the first two bytes of clockSeqAndNode.

Unfortunately, fixing this breaks compatibility between how TAs are
built, and when the OS loads them.

With this patch UUID string are formated with the additional hyphen as
for instance: f81d4fae-7dec-11d0-a765-00a0c91e6bf6

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Fixes: OP-TEE/optee_os#857
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
jenswi-linaro added a commit to jenswi-linaro/optee_client that referenced this issue Dec 9, 2016
@jenswi-linaro
Format UUID strings correctly
ce5fefe 
Prior to this patch although GlobalPlatform specifies that TAs and such
are identified with UUIDs, we don't format them quite right when turning
them into strings. Per https://www.ietf.org/rfc/rfc4122.txt, there
should be another hyphen after the first two bytes of clockSeqAndNode.

Unfortunately, fixing this breaks compatibility between how TAs are
built, and when the OS loads them.

With this patch UUID string are formated with the additional hyphen as
for instance: f81d4fae-7dec-11d0-a765-00a0c91e6bf6

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Fixes: OP-TEE/optee_os#857
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
jenswi-linaro added a commit to jenswi-linaro/optee_os that referenced this issue Dec 9, 2016
@jenswi-linaro
Format UUID strings correctly
d2f5c00 
Prior to this patch although GlobalPlatform specifies that TAs and such
are identified with UUIDs, we don't format them quite right when turning
them into strings. Per https://www.ietf.org/rfc/rfc4122.txt, there
should be another hyphen after the first two bytes of clockSeqAndNode.

Unfortunately, fixing this breaks compatibility between how TAs are
built, and when the OS loads them.

With this patch UUID string are formated with the additional hyphen as
for instance: f81d4fae-7dec-11d0-a765-00a0c91e6bf6

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Fixes: OP-TEE#857
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
jenswi-linaro added a commit to jenswi-linaro/optee_os that referenced this issue Dec 9, 2016
@jenswi-linaro
Format UUID strings correctly
59c2b6b 
Prior to this patch although GlobalPlatform specifies that TAs and such
are identified with UUIDs, we don't format them quite right when turning
them into strings. Per https://www.ietf.org/rfc/rfc4122.txt, there
should be another hyphen after the first two bytes of clockSeqAndNode.

Unfortunately, fixing this breaks compatibility between how TAs are
built, and when the OS loads them.

With this patch UUID string are formated with the additional hyphen as
for instance: f81d4fae-7dec-11d0-a765-00a0c91e6bf6

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Fixes: OP-TEE#857
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
takuya-sakata pushed a commit to renesas-rcar/optee_os that referenced this issue Dec 22, 2017
@jenswi-linaro @takuya-sakata
Format UUID strings correctly
2ac999d 
Prior to this patch although GlobalPlatform specifies that TAs and such
are identified with UUIDs, we don't format them quite right when turning
them into strings. Per https://www.ietf.org/rfc/rfc4122.txt, there
should be another hyphen after the first two bytes of clockSeqAndNode.

Unfortunately, fixing this breaks compatibility between how TAs are
built, and when the OS loads them.

With this patch UUID string are formated with the additional hyphen as
for instance: f81d4fae-7dec-11d0-a765-00a0c91e6bf6

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Fixes: OP-TEE/optee_os#857
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU)
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
larrygwinn pushed a commit to nxp-archive/imxat_tee_optee-test that referenced this issue Aug 12, 2022
@jenswi-linaro
Format UUID strings correctly
2183835 
Prior to this patch although GlobalPlatform specifies that TAs and such
are identified with UUIDs, we don't format them quite right when turning
them into strings. Per https://www.ietf.org/rfc/rfc4122.txt, there
should be another hyphen after the first two bytes of clockSeqAndNode.

Unfortunately, fixing this breaks compatibility between how TAs are
built, and when the OS loads them.

With this patch UUID string are formated with the additional hyphen as
for instance: f81d4fae-7dec-11d0-a765-00a0c91e6bf6

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Fixes: OP-TEE/optee_os#857
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Format UUID strings correctly jenswi-linaro/optee_test
2 participants
@d3zd3z @jforissier