Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plat-mediatek: add support for MT8188 SoC #6333

Merged
merged 1 commit into from
Oct 3, 2023
Merged

plat-mediatek: add support for MT8188 SoC #6333

merged 1 commit into from
Oct 3, 2023

Conversation

ZheTing815
Copy link
Contributor

Add OP-TEE support for the MT8188 SoC.

Copy link
Contributor

@jforissier jforissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

I am not sure at all that two Signed-off-by are needed or even valid given that they represent the same person but with a different email. Would you mind choosing one? (it has to be the same than in the Author field, so if you don't change Author in the git settings, you should keep the google.com one)

Another thing: plat-mediatek has no more official maintainer in MAINTAINERS, would you like to add yourself?

Add OP-TEE support for the MT8188 SoC.

Signed-off-by: Gavin Liu <gavin.liu@mediatek.com>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
@ZheTing815
Copy link
Contributor Author

ZheTing815 commented Oct 3, 2023

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

I am not sure at all that two Signed-off-by are needed or even valid given that they represent the same person but with a different email. Would you mind choosing one? (it has to be the same than in the Author field, so if you don't change Author in the git settings, you should keep the google.com one)

Ok, I just modified the author.

Another thing: plat-mediatek has no more official maintainer in MAINTAINERS, would you like to add yourself?

Hmm, I consider myself not a suitable person for it.

@jforissier
Copy link
Contributor

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
I am not sure at all that two Signed-off-by are needed or even valid given that they represent the same person but with a different email. Would you mind choosing one? (it has to be the same than in the Author field, so if you don't change Author in the git settings, you should keep the google.com one)

Ok, I just modified the author.

Thanks!

Another thing: plat-mediatek has no more official maintainer in MAINTAINERS, would you like to add yourself?

Hmm, I consider myself not a suitable person for it.

That's fine.

@jforissier jforissier merged commit ace93cc into OP-TEE:master Oct 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants