Add Widevine related device tree options support #6379

qazwsxedcrfvtg14 · 2023-10-13T08:52:25Z

On the new ChromeOS mediatek platform, we will use the device tree to pass hardware unique key and the parameters for widevine TA.

BTW, should we also put the device tree binding document in the OP-TEE repo?
Because the Linux upstream says the OP-TEE only DT bindings don't belong in the kernel.
https://lore.kernel.org/all/20230918194235.GA1548023-robh@kernel.org/

jbech-linaro

As a generic comment I think we'd like to change this to transfer lists, transfer elements in the future. But until that is in place DT works.

core/pta/widevine.c

core/arch/arm/plat-mediatek/cros_huk.c

mk/config.mk

core/arch/arm/plat-mediatek/cros_huk.c

core/pta/widevine.c

qazwsxedcrfvtg14 · 2023-10-23T15:13:05Z

Added a new commit to resolve comments.

jbech-linaro · 2023-11-01T13:53:37Z

I think this is good now, please add my tag, rebase it and squash the patches accordingly so we merge it. Thanks!

Reviewed-by: Joakim Bech <joakim.bech@linaro.org>

qazwsxedcrfvtg14 · 2023-11-03T03:37:09Z

Rebased and squashed the patches.
Thanks!

jforissier · 2023-11-03T08:48:50Z

@qazwsxedcrfvtg14 please address the checkpatch issues (CI / Code style job). You may use the sentence you put in this PR ("On the new ChromeOS mediatek platform, we will use the device tree to pass hardware unique key and the parameters for widevine TA.").
Thanks.

etienne-lms

Are these DT bindings (DT node pathes as /options/ and property names) generic? Are they OP-TEE specific (e.g optee-hardware-unique-key) ? If these are to be deprecated once Firmware Handoff Transfer List is merged, is it worth merging this change now?

The commit message lacks a description, see CI Code Style result that also reports another issue).

core/pta/widevine.c

mk/config.mk

core/drivers/widevine_huk.c

core/pta/widevine.c

qazwsxedcrfvtg14 · 2023-11-03T12:27:25Z

Resolved the comments.

BTW, I'm not sure about the status of "Firmware Handoff Transfer List"...
@Narflex do we have any plans for that?

Narflex · 2023-11-03T17:14:58Z

Resolved the comments.

BTW, I'm not sure about the status of "Firmware Handoff Transfer List"... @Narflex do we have any plans for that?

I'm not sure about our future plans for that, but it's not in the timeline for this change, so please proceed with this change as-is.

etienne-lms · 2023-11-03T17:57:52Z

so please proceed with this change as-is.

Please check first that such /options/ DT node paths and new DT property are not a open door to messy DT bindings.
DT bindings is a spec. It should remain somewhat consistent. Thanks for #6418, that helps discussion on a real proposal. Is it clear who is in charge of maintaining these bindings evolution and consistency. It seems the pointed discussion thread did not lead to a definitive consensus. Unless I missed something in which case I apologies for being noisy.

Narflex · 2023-11-03T18:49:48Z

so please proceed with this change as-is.

Please check first that such /options/ DT node paths and new DT property are not a open door to messy DT bindings. DT bindings is a spec. It should remain somewhat consistent. Thanks for #6418, that helps discussion on a real proposal. Is it clear who is in charge of maintaining these bindings evolution and consistency. It seems the pointed discussion thread did not lead to a definitive consensus. Unless I missed something in which case I apologies for being noisy.

The DT bindings being added here are being documented in OP-TEE as you pointed out, so I would figure OP-TEE maintainers would be the ones maintaining the evolution/consistency of that if anything else gets added there in the future. Originally we tried to get these documented in the linux kernel, but got pushback on that which is why they ended up in OP-TEE....and I think that stance will continue to be taken where DT bindings should get added to kernel documentation unless there is pushback on that end, in which case they'd end up in OP-TEE.

core/drivers/widevine_huk.c

core/pta/widevine.c

lib/libutee/include/pta_widevine.h

mk/config.mk

core/pta/widevine.c

core/drivers/widevine_huk.c

lib/libutee/include/pta_widevine.h

mk/config.mk

core/pta/widevine.c

qazwsxedcrfvtg14 · 2023-11-10T03:50:00Z

Rebased and resolved the conflicts with master branch.

core/drivers/sub.mk

core/pta/widevine.c

mk/config.mk

core/drivers/widevine_huk.c

qazwsxedcrfvtg14 · 2023-11-10T07:29:52Z

Resolved the comments.

etienne-lms

I would rather wait the DT bindings are acked before merging this change.

I still find curious that Widevine mandates the whole OP-TEE to rely on a HUK provided by DT "/options/op-tee/widevine" node without other strict constraints on how this HUK is derived. I also think it puts some restrictions on integration of other TAs when the Widevine TA is to be supported, which maybe makes sense.

jbech-linaro · 2023-11-23T09:28:37Z

I'm adding the "enhancement" tag, so this won't be closed automatically and since I want this to be merged in one or another way at some point. I do believe this will take some time to sort out. We've just this week had a first call between stakeholders interested in this and we concluded that we have to start with working out the Linux kernel side of things. The secure side, will be a topic in the future when the Linux kernel side of story seems to fall in place. For more information (and a recording of the meeting), please see the topics discussed here.

core/drivers/widevine_huk.c

qazwsxedcrfvtg14 · 2024-02-01T00:37:09Z

The device tree binding is merged in the optee_docs:
OP-TEE/optee_docs#230

And rebased the PR.

jbech-linaro · 2024-02-01T11:40:03Z

@jforissier @jenswi-linaro anything else you'd like to add?

core/pta/widevine.c

jenswi-linaro · 2024-02-02T07:38:18Z

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

jforissier

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

On the new ChromeOS mediatek platform, we will use the device tree to pass hardware unique key and the parameters for widevine TAs. Signed-off-by: Yi Chou <yich@google.com> Reviewed-by: Joakim Bech <joakim.bech@linaro.org> Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

Narflex · 2024-02-08T22:11:12Z

Can we get this PR merged now?

jforissier · 2024-02-09T08:03:17Z

@Narflex yes, sorry for the delay.

jbech-linaro reviewed Oct 20, 2023

View reviewed changes

etienne-lms reviewed Oct 20, 2023

View reviewed changes

qazwsxedcrfvtg14 mentioned this pull request Nov 1, 2023

dt-bindings: Add Google Widevine initialization parameters #6418

Closed

qazwsxedcrfvtg14 force-pushed the master branch from c6fd863 to 444564f Compare November 2, 2023 04:54

etienne-lms suggested changes Nov 3, 2023

View reviewed changes

core/pta/widevine.c Show resolved Hide resolved

core/pta/widevine.c Outdated Show resolved Hide resolved

core/pta/widevine.c Outdated Show resolved Hide resolved

mk/config.mk Outdated Show resolved Hide resolved

etienne-lms reviewed Nov 3, 2023

View reviewed changes

core/drivers/widevine_huk.c Show resolved Hide resolved

core/pta/widevine.c Outdated Show resolved Hide resolved

qazwsxedcrfvtg14 force-pushed the master branch 2 times, most recently from 43fc6bf to 77915f0 Compare November 3, 2023 12:15

etienne-lms reviewed Nov 3, 2023

View reviewed changes

qazwsxedcrfvtg14 force-pushed the master branch 3 times, most recently from 7b5bf12 to e59bff8 Compare November 6, 2023 07:05

etienne-lms reviewed Nov 6, 2023

View reviewed changes

qazwsxedcrfvtg14 force-pushed the master branch 2 times, most recently from df3a5ac to e2fa2b1 Compare November 6, 2023 09:10

qazwsxedcrfvtg14 mentioned this pull request Nov 9, 2023

schemas: Add Google Widevine initialization parameters devicetree-org/dt-schema#115

Closed

qazwsxedcrfvtg14 force-pushed the master branch 2 times, most recently from 90669a8 to d3a0066 Compare November 10, 2023 03:49

etienne-lms reviewed Nov 10, 2023

View reviewed changes

qazwsxedcrfvtg14 force-pushed the master branch from d3a0066 to bfb5f9d Compare November 10, 2023 07:26

etienne-lms reviewed Nov 10, 2023

View reviewed changes

jbech-linaro added the enhancement label Nov 23, 2023

qazwsxedcrfvtg14 force-pushed the master branch 2 times, most recently from c7efeb3 to 9f85553 Compare December 4, 2023 08:30

Narflex reviewed Dec 4, 2023

View reviewed changes

core/drivers/widevine_huk.c Show resolved Hide resolved

qazwsxedcrfvtg14 force-pushed the master branch from 9f85553 to 711bed1 Compare December 5, 2023 01:27

qazwsxedcrfvtg14 closed this Feb 1, 2024

qazwsxedcrfvtg14 force-pushed the master branch from 711bed1 to 64a52f9 Compare February 1, 2024 00:32

qazwsxedcrfvtg14 reopened this Feb 1, 2024

jenswi-linaro reviewed Feb 1, 2024

View reviewed changes

core/pta/widevine.c Outdated Show resolved Hide resolved

core/pta/widevine.c Outdated Show resolved Hide resolved

qazwsxedcrfvtg14 force-pushed the master branch from 16227e7 to d09effd Compare February 2, 2024 07:04

jforissier reviewed Feb 2, 2024

View reviewed changes

qazwsxedcrfvtg14 force-pushed the master branch from d09effd to 8634308 Compare February 2, 2024 08:05

jforissier merged commit ad19495 into OP-TEE:master Feb 9, 2024
6 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Widevine related device tree options support #6379

Add Widevine related device tree options support #6379

qazwsxedcrfvtg14 commented Oct 13, 2023

jbech-linaro left a comment

qazwsxedcrfvtg14 commented Oct 23, 2023

jbech-linaro commented Nov 1, 2023

qazwsxedcrfvtg14 commented Nov 3, 2023

jforissier commented Nov 3, 2023

etienne-lms left a comment

qazwsxedcrfvtg14 commented Nov 3, 2023

Narflex commented Nov 3, 2023

etienne-lms commented Nov 3, 2023

Narflex commented Nov 3, 2023

qazwsxedcrfvtg14 commented Nov 10, 2023

qazwsxedcrfvtg14 commented Nov 10, 2023

etienne-lms left a comment

jbech-linaro commented Nov 23, 2023

qazwsxedcrfvtg14 commented Feb 1, 2024

jbech-linaro commented Feb 1, 2024

jenswi-linaro commented Feb 2, 2024

jforissier left a comment

Narflex commented Feb 8, 2024

jforissier commented Feb 9, 2024

Add Widevine related device tree options support #6379

Add Widevine related device tree options support #6379

Conversation

qazwsxedcrfvtg14 commented Oct 13, 2023

jbech-linaro left a comment

Choose a reason for hiding this comment

qazwsxedcrfvtg14 commented Oct 23, 2023

jbech-linaro commented Nov 1, 2023

qazwsxedcrfvtg14 commented Nov 3, 2023

jforissier commented Nov 3, 2023

etienne-lms left a comment

Choose a reason for hiding this comment

qazwsxedcrfvtg14 commented Nov 3, 2023

Narflex commented Nov 3, 2023

etienne-lms commented Nov 3, 2023

Narflex commented Nov 3, 2023

qazwsxedcrfvtg14 commented Nov 10, 2023

qazwsxedcrfvtg14 commented Nov 10, 2023

etienne-lms left a comment

Choose a reason for hiding this comment

jbech-linaro commented Nov 23, 2023

qazwsxedcrfvtg14 commented Feb 1, 2024

jbech-linaro commented Feb 1, 2024

jenswi-linaro commented Feb 2, 2024

jforissier left a comment

Choose a reason for hiding this comment

Narflex commented Feb 8, 2024

jforissier commented Feb 9, 2024