Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dt-bindings: Add Google Widevine initialization parameters #6418

Closed
wants to merge 1 commit into from

Conversation

qazwsxedcrfvtg14
Copy link
Contributor

The necessary fields to initialize the widevine related functions in OP-TEE.

In the previous discussion on the TF-A CL, we think this DT binding file should be placed in the optee repo.
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/20442/comment/bfbdaa52_659557e0/
But I didn't find a good way to convert the .yaml binding file to a .rst file.
Should we put the binding file in the optee_os repo?


The DT usage in the OP-TEE:
#6379

The TF-A CL:
https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/20442/19

The previous discussions in the linux kernel mailing list:
https://lore.kernel.org/all/20230918194235.GA1548023-robh@kernel.org/
https://lore.kernel.org/all/CABOkjxJwT3zZfgsK8oiubQVZCZDPg6mJ8Et99yAyanp7oOLPmg@mail.gmail.com/

The necessary fields to initialize the widevine related functions in
OP-TEE.

Signed-off-by: Yi Chou <yich@google.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
@jenswi-linaro
Copy link
Contributor

In https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/20442/11..19/services/spd/opteed/opteed_main.c#b263 it was suggested that this should go into the documentation instead of this git.

Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For info and aside this Widevine specific P-R:
I'm in favor of having OP-TEE specific DT bindings defined in an open-source repository, being OP-TEE OS or another. This will help to sanitize DTB built from optee_os source tree.

I withdraw my comments about "/options" node path. It is indeed specified in dt-schemas.git since devicetree-org/dt-schema@9db185f. However, since these bindings are related to OP-TEE, I think this windevine node should located at path /options/op-tee/widevine, as U-Boot gets its boot-time parameters from the /options/u-boot subnode. Could dt-schema.git be updated to reflect that /options/op-tee hold data passed to OP-TEE?

@qazwsxedcrfvtg14
Copy link
Contributor Author

Opened another PR in the dt-schema repo:
devicetree-org/dt-schema#115

@qazwsxedcrfvtg14
Copy link
Contributor Author

The PR had been moved to the devicetree-spec mailing list:
https://lore.kernel.org/all/20231113075249.3807225-1-yich@chromium.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants