Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GDS] Add Method GetCertificates to GDS for Pull Support and ServerConfiguration for Push Support / Fix CheckRevocationStatus #2553

Merged
merged 16 commits into from
Jun 5, 2024

fix test on Linux by checking only for "BadCertificate" StatusCode

2dcfd1c
Select commit
Loading
Failed to load commit list.
Merged

[GDS] Add Method GetCertificates to GDS for Pull Support and ServerConfiguration for Push Support / Fix CheckRevocationStatus #2553

fix test on Linux by checking only for "BadCertificate" StatusCode
2dcfd1c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 30, 2024 in 0s

54.63% (-0.02%) compared to a6f44c7

View this Pull Request on Codecov

54.63% (-0.02%) compared to a6f44c7

Details

Codecov Report

Attention: Patch coverage is 62.76596% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 54.63%. Comparing base (a6f44c7) to head (2dcfd1c).

Files Patch % Lines
...pc.Ua.Gds.Server.Common/ApplicationsNodeManager.cs 44.00% 23 Missing and 5 partials ⚠️
...a.Server/Configuration/ConfigurationNodeManager.cs 78.57% 2 Missing and 1 partial ⚠️
...a.Gds.Client.Common/GlobalDiscoveryServerClient.cs 84.61% 1 Missing and 1 partial ⚠️
...Gds.Client.Common/ServerPushConfigurationClient.cs 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2553      +/-   ##
==========================================
- Coverage   54.64%   54.63%   -0.02%     
==========================================
  Files         342      342              
  Lines       65056    65140      +84     
  Branches    13335    13349      +14     
==========================================
+ Hits        35550    35587      +37     
- Misses      25641    25677      +36     
- Partials     3865     3876      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov