Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reopen secure channel without activate #2577

Merged
merged 14 commits into from
Jun 2, 2024

code review fixes

e61785b
Select commit
Loading
Failed to load commit list.
Merged

Fix reopen secure channel without activate #2577

code review fixes
e61785b
Select commit
Loading
Failed to load commit list.
Azure Pipelines / OPCFoundation.UA-.NETStandard succeeded May 15, 2024 in 26m 51s

Build #1.5.374.60-preview+e61785b4d9 had test failures

Details

Tests

  • Failed: 2 (0.00%, 2 new, 0 recurring)
  • Passed: 112,696 (98.77%)
  • Other: 1,396 (1.22%)
  • Total: 114,094

Annotations

Check failure on line 1 in Opc.Ua.Client.Tests.ClientTest("https").ReconnectSessionOnAlternateChannel(False,True)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / OPCFoundation.UA-.NETStandard

Opc.Ua.Client.Tests.ClientTest("https").ReconnectSessionOnAlternateChannel(False,True)

Opc.Ua.ServiceResultException : Channel has been closed.
Raw output
   at Opc.Ua.ClientBase.get_TransportChannel() in /_/Stack/Opc.Ua.Core/Stack/Client/ClientBase.cs:line 119
   at Opc.Ua.SessionClient.EndActivateSession(IAsyncResult result, Byte[]& serverNonce, StatusCodeCollection& results, DiagnosticInfoCollection& diagnosticInfos) in /_/Stack/Opc.Ua.Core/Stack/Generated/Opc.Ua.Client.cs:line 2153
   at Opc.Ua.Client.Session.<ReconnectAsync>d__328.MoveNext() in /_/Libraries/Opc.Ua.Client/SessionAsync.cs:line 1541
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Opc.Ua.Client.Session.<ReconnectAsync>d__328.MoveNext() in /_/Libraries/Opc.Ua.Client/SessionAsync.cs:line 1566
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Opc.Ua.Client.TraceableSession.<ReconnectAsync>d__126.MoveNext() in /_/Libraries/Opc.Ua.Client/TraceableSession.cs:line 347
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Opc.Ua.Client.Tests.ClientTest.<ReconnectSessionOnAlternateChannel>d__24.MoveNext() in /_/Tests/Opc.Ua.Client.Tests/ClientTest.cs:line 652
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await[TResult](Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__0()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)

Check failure on line 1 in Opc.Ua.Client.Tests.ClientTest("opc.https").ReconnectSessionOnAlternateChannel(True,False)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / OPCFoundation.UA-.NETStandard

Opc.Ua.Client.Tests.ClientTest("opc.https").ReconnectSessionOnAlternateChannel(True,False)

Opc.Ua.ServiceResultException : Channel has been closed.
Raw output
   at Opc.Ua.ClientBase.get_TransportChannel() in /_/Stack/Opc.Ua.Core/Stack/Client/ClientBase.cs:line 119
   at Opc.Ua.SessionClient.BeginActivateSession(RequestHeader requestHeader, SignatureData clientSignature, SignedSoftwareCertificateCollection clientSoftwareCertificates, StringCollection localeIds, ExtensionObject userIdentityToken, SignatureData userTokenSignature, AsyncCallback callback, Object asyncState) in /_/Stack/Opc.Ua.Core/Stack/Generated/Opc.Ua.Client.cs:line 2141
   at Opc.Ua.Client.Session.PrepareReconnectBeginActivate(ITransportWaitingConnection connection, ITransportChannel transportChannel) in /_/Libraries/Opc.Ua.Client/Session.cs:line 5697
   at Opc.Ua.Client.Session.Reconnect(ITransportWaitingConnection connection, ITransportChannel transportChannel) in /_/Libraries/Opc.Ua.Client/Session.cs:line 1439
   at Opc.Ua.Client.Session.Reconnect(ITransportChannel channel) in /_/Libraries/Opc.Ua.Client/Session.cs:line 1411
   at Opc.Ua.Client.TraceableSession.Reconnect(ITransportChannel channel) in /_/Libraries/Opc.Ua.Client/TraceableSession.cs:line 320
   at Opc.Ua.Client.Tests.ClientTest.ReconnectSessionOnAlternateChannel(Boolean closeChannel, Boolean asyncReconnect) in /_/Tests/Opc.Ua.Client.Tests/ClientTest.cs:line 656
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await[TResult](Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.BeforeAndAfterTestCommand.<>c__DisplayClass1_0.<Execute>b__0()
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)