Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reopen secure channel without activate #2577

Merged
merged 14 commits into from
Jun 2, 2024

code review fixes

e61785b
Select commit
Loading
Failed to load commit list.
Merged

Fix reopen secure channel without activate #2577

code review fixes
e61785b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded May 15, 2024 in 1s

58.71% of diff hit (target 54.64%)

View this Pull Request on Codecov

58.71% of diff hit (target 54.64%)

Annotations

Check warning on line 767 in Libraries/Opc.Ua.Client/Session.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Libraries/Opc.Ua.Client/Session.cs#L767 

Added line #L767 was not covered by tests

Check warning on line 1447 in Libraries/Opc.Ua.Client/Session.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Libraries/Opc.Ua.Client/Session.cs#L1445-L1447 

Added lines #L1445 - L1447 were not covered by tests

Check warning on line 3917 in Libraries/Opc.Ua.Client/Session.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Libraries/Opc.Ua.Client/Session.cs#L3916-L3917 

Added lines #L3916 - L3917 were not covered by tests

Check warning on line 3985 in Libraries/Opc.Ua.Client/Session.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Libraries/Opc.Ua.Client/Session.cs#L3985 

Added line #L3985 was not covered by tests

Check warning on line 5126 in Libraries/Opc.Ua.Client/Session.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Libraries/Opc.Ua.Client/Session.cs#L5126 

Added line #L5126 was not covered by tests

Check warning on line 1337 in Libraries/Opc.Ua.Client/SessionAsync.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Libraries/Opc.Ua.Client/SessionAsync.cs#L1337 

Added line #L1337 was not covered by tests

Check warning on line 1521 in Libraries/Opc.Ua.Client/SessionAsync.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Libraries/Opc.Ua.Client/SessionAsync.cs#L1518-L1521 

Added lines #L1518 - L1521 were not covered by tests

Check warning on line 1523 in Libraries/Opc.Ua.Client/SessionAsync.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Libraries/Opc.Ua.Client/SessionAsync.cs#L1523 

Added line #L1523 was not covered by tests

Check warning on line 1527 in Libraries/Opc.Ua.Client/SessionAsync.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Libraries/Opc.Ua.Client/SessionAsync.cs#L1527 

Added line #L1527 was not covered by tests

Check warning on line 437 in Libraries/Opc.Ua.Client/SessionReconnectHandler.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Libraries/Opc.Ua.Client/SessionReconnectHandler.cs#L436-L437 

Added lines #L436 - L437 were not covered by tests

Check warning on line 501 in Libraries/Opc.Ua.Client/SessionReconnectHandler.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Libraries/Opc.Ua.Client/SessionReconnectHandler.cs#L501 

Added line #L501 was not covered by tests

Check warning on line 96 in Stack/Opc.Ua.Core/Stack/Client/ClientBase.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Stack/Opc.Ua.Core/Stack/Client/ClientBase.cs#L96 

Added line #L96 was not covered by tests

Check warning on line 442 in Stack/Opc.Ua.Core/Stack/Tcp/ChannelAsyncOperation.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Stack/Opc.Ua.Core/Stack/Tcp/ChannelAsyncOperation.cs#L442 

Added line #L442 was not covered by tests

Check warning on line 454 in Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryChannel.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryChannel.cs#L454 

Added line #L454 was not covered by tests

Check warning on line 800 in Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L800 

Added line #L800 was not covered by tests

Check warning on line 835 in Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L835 

Added line #L835 was not covered by tests

Check warning on line 838 in Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L838 

Added line #L838 was not covered by tests

Check warning on line 947 in Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L947 

Added line #L947 was not covered by tests

Check warning on line 958 in Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L958 

Added line #L958 was not covered by tests

Check warning on line 1335 in Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L1334-L1335 

Added lines #L1334 - L1335 were not covered by tests

Check warning on line 1342 in Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs#L1342 

Added line #L1342 was not covered by tests

Check warning on line 366 in Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryTransportChannel.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryTransportChannel.cs#L365-L366 

Added lines #L365 - L366 were not covered by tests
View more details on Codecov