Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reopen secure channel without activate #2577

Merged
merged 14 commits into from
Jun 2, 2024

code review fixes

e61785b
Select commit
Loading
Failed to load commit list.
Merged

Fix reopen secure channel without activate #2577

code review fixes
e61785b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 15, 2024 in 0s

54.52% (-0.12%) compared to 52d4492

View this Pull Request on Codecov

54.52% (-0.12%) compared to 52d4492

Details

Codecov Report

Attention: Patch coverage is 58.71560% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 54.52%. Comparing base (52d4492) to head (e61785b).
Report is 1 commits behind head on master.

Files Patch % Lines
Libraries/Opc.Ua.Client/Session.cs 71.05% 9 Missing and 2 partials ⚠️
...k/Opc.Ua.Core/Stack/Tcp/UaSCBinaryClientChannel.cs 66.66% 8 Missing and 3 partials ⚠️
Libraries/Opc.Ua.Client/SessionAsync.cs 23.07% 9 Missing and 1 partial ⚠️
Libraries/Opc.Ua.Client/SessionReconnectHandler.cs 33.33% 4 Missing ⚠️
Stack/Opc.Ua.Core/Stack/Tcp/UaSCBinaryChannel.cs 50.00% 1 Missing and 2 partials ⚠️
...pc.Ua.Core/Stack/Tcp/UaSCBinaryTransportChannel.cs 25.00% 2 Missing and 1 partial ⚠️
...ack/Opc.Ua.Core/Stack/Tcp/ChannelAsyncOperation.cs 60.00% 1 Missing and 1 partial ⚠️
Stack/Opc.Ua.Core/Stack/Client/ClientBase.cs 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2577      +/-   ##
==========================================
- Coverage   54.64%   54.52%   -0.12%     
==========================================
  Files         343      343              
  Lines       65218    65270      +52     
  Branches    13354    13365      +11     
==========================================
- Hits        35637    35591      -46     
- Misses      25702    25794      +92     
- Partials     3879     3885       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov